fix:picker、scroll、slide component cannot scroll on some kind of pc de… #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: minute step rule * docs: chinese * fix: number value * test: minuteStep * docs: update * fix: min hour change caused by ceil * test: add case
* feat: max * test(time-picker): max example * fix(time-picker): days.len * docs: max * fix(time-picker): column init * test(time-picker): max * docs: max * test: fix minute step * fix: potential float bug * feat(time-picker): min * test(time-picker): min * docs(time-picker): min * docs(time-picker): min, max
* chore: update scroll example's img * chore: replace img links
* fix(slide): goToPage direction * fix: remove default time value in goToPage function
Codecov Report
@@ Coverage Diff @@
## dev #398 +/- ##
=========================================
- Coverage 92.77% 92.68% -0.1%
=========================================
Files 141 138 -3
Lines 3074 2965 -109
Branches 498 489 -9
=========================================
- Hits 2852 2748 -104
+ Misses 117 108 -9
- Partials 105 109 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for solving the issue #397.
In the code of picker、scroll、slide component, I set the configure of "disableMouse" to "false", which is the configure of better-scroll. This change is to solving problem that those components cannot be use on some PC devices, which have touch event on the window object.