estimate mu*D from z-scan file #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yucongalicechen
commented
Sep 11, 2024
•
yucongalicechen
commented
- closes estimate mud from z-scan file #100
- added the function for computing mud in a new module and relevant test functions
- added an optional argument that takes in a z-scan file and a function in tools.py to process that file and update mud
- I did this in one setting so I put all work in one PR, but I can split into multiple PRs if that's easier to review!
|
@yucongalicechen this has conflicts that need resolving |
Okay, I resolved the conflicts. It is ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.