New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement fast_cve module #86

Merged

sbillinge merged 6 commits into diffpy:main from yucongalicechen:fast_cve

Jul 25, 2024

Collaborator

yucongalicechen commented Jul 24, 2024

addressing issue Implement quick calculation #85 (will address the last bullet point about labpdfprocapp.py in another PR)
functions and tests are very similar to what's in functions.py
would like some advice on renaming some variables/functions to make them more readable

yucongalicechen added 6 commits

July 24, 2024 12:24


          load precomputed datasets and define global variables

9b7d92d


          add function for fast computation

6f5776a


          add tests for compute_cve, change datasets paths to absolute paths

10b0d5f


          add function for applying correction and its test

e0d27e6


          add pandas to required packages

e7814ef


          add scipy

884be46

sbillinge merged commit 0943e07 into diffpy:main

5 checks passed

Contributor

sbillinge commented Jul 25, 2024

wow, super, merged in one!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet