Fix bugs to run tutorial CLI, update python, matplotlib API #137
Conversation
| print("Could not find ModelEvaluator '%s'. Exiting." % options.modelevaluator) | ||
| return | ||
|
|
||
| if options.bcrystal: |
There was a problem hiding this comment.
No need to use is not None since False is the default value.
| if vals != range(self.npars): | ||
|
|
||
| # Check if the sorted values match the sequence from 0 to npars-1 | ||
| if vals != list(range(self.npars)): |
There was a problem hiding this comment.
Bug fix - compare list against list in the latest Python
There was a problem hiding this comment.
Let's dump an issue to handle this better too. It strikes me as a brittle design. But don't fix this in this release. Something for a new group member.
| options.peakfunction = eval("peaks." + options.peakfunction) | ||
| except Exception as err: | ||
| print(err) | ||
| print("Could not create peak function '%s'. Exiting." % options.peakfunction) |
There was a problem hiding this comment.
These error messages could be improved by giving the user hints about how to fix them. Let's make an issue to make them more informative for the user, but don't worry about closing that issue in this release.
In general we need tests in srmise (please can you make an issue for that too?)
| if vals != range(self.npars): | ||
|
|
||
| # Check if the sorted values match the sequence from 0 to npars-1 | ||
| if vals != list(range(self.npars)): |
There was a problem hiding this comment.
Let's dump an issue to handle this better too. It strikes me as a brittle design. But don't fix this in this release. Something for a new group member.
Closes #136
Closes #104
srmise data/Ag_nyquist_qmax30.gr --no-extract --plotrenders:srmise data/Ag_nyquist_qmax30.gr --no-extract --plot --range 2 3.5renders: