skpkg: set up scaffold and moved over docs, src, tests, news #165
Conversation
There was a problem hiding this comment.
this is a great start! In general, pay close attention to things that appear as deleted in these modified files. We often want to keep things from the old package that are being deleted. OK if you miss some, that is what I am here for, and feel free to ask questions.
| dynamic=['version', 'dependencies'] | ||
| authors = [ | ||
| { name="Simon J.L. Billinge group", email="[email protected]" }, | ||
| {name="Luke Granlund", email="[email protected]"}, |
There was a problem hiding this comment.
we want to keep Luke's name. We never want to "drop" authors.
pyproject.toml
Outdated
| requires-python = ">=3.11, <3.14" | ||
| classifiers = [ | ||
| 'Development Status :: 3 - Alpha', | ||
| 'Development Status :: 5 - Production/Stable', |
There was a problem hiding this comment.
this should probably stay as 3 or 4
| dev_template = "{tag}" | ||
| dirty_template = "{tag}" | ||
|
|
||
| [project.scripts] |
|
Ok seems like I missed those. Will keep an eye out in the future |
|
They are honestly easy to catch by looking at the PR on github.... |
|
Ok I see. I will double check the files changed before making the PR in the future |
|
In a case like this, should I go back and fix the files that were modified? |
|
I have fixed the file |
|
nice @kwagoner94 perfectly done. sync your main to upstream and let's go to the next step. |
* skpkg: set up scaffold and moved over docs, src, tests, news (#165) * fix: chagned line length to 115 * chore: move LICENSE files over to scaffold * fix: Fixed issues with pyproject.toml * chore: move necessary files over to scaffold (#166) * fix: chagned line length to 115 * chore: move LICENSE files over to scaffold * chore: github workflows, codecovs, codespell * chore: maintenance on CHANGLOG CODE_OF_CONDUCT etc * chore: move neccessary files over, clean up ones that arent needed * skpkg: fix pyproject.toml * [pre-commit.ci] auto fixes from pre-commit hooks * chore: Replace scikit-package-logo-text.png and example-table.rst with placeholder files, fix docformatter for arbitrary.py * [pre-commit.ci] auto fixes from pre-commit hooks --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: move over rest of doc and src files (#168) * chore: move over rest of doc and src files * chore: run pre-commit * chore: fix index.rst back to original * Rename doc → docs, update references, and fix test.txt (#171) --------- Co-authored-by: kwagoner94 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2 participants
No description provided.