Skip to content

Conversation

kwagoner94
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (migration@451da4d). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff              @@
##             migration     #166   +/-   ##
============================================
  Coverage             ?   76.47%           
============================================
  Files                ?        3           
  Lines                ?       51           
  Branches             ?        0           
============================================
  Hits                 ?       39           
  Misses               ?       12           
  Partials             ?        0           
Files with missing lines Coverage Δ
tests/test_version.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace the scikit-package png image in the img folder with an empty file called .placeholder. Likewise, remove the example file from snippers and replace it with a .placeholder file. You can generate these with the touch command in bash.

Other than that there is just one comment inline that needs attention I think and then I can merge this. Huge PR! Nicely done.

@sbillinge sbillinge merged commit a7c4a9d into diffpy:migration Jun 24, 2025
2 checks passed
@kwagoner94 kwagoner94 deleted the modified_one branch June 24, 2025 03:40
sbillinge added a commit that referenced this pull request Jul 9, 2025
* skpkg: set up scaffold and moved over docs, src, tests, news (#165)

* fix: chagned line length to 115

* chore: move LICENSE files over to scaffold

* fix: Fixed issues with pyproject.toml

* chore: move necessary files over to scaffold (#166)

* fix: chagned line length to 115

* chore: move LICENSE files over to scaffold

* chore: github workflows, codecovs, codespell

* chore: maintenance on CHANGLOG CODE_OF_CONDUCT etc

* chore: move neccessary files over, clean up ones that arent needed

* skpkg: fix pyproject.toml

* [pre-commit.ci] auto fixes from pre-commit hooks

* chore: Replace scikit-package-logo-text.png and example-table.rst with placeholder files, fix docformatter for arbitrary.py

* [pre-commit.ci] auto fixes from pre-commit hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: move over rest of doc and src files (#168)

* chore: move over rest of doc and src files

* chore: run pre-commit

* chore: fix index.rst back to original

* Rename doc → docs, update references, and fix test.txt (#171)

---------

Co-authored-by: kwagoner94 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants