-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mainquest: Move css-modules to plain css #1846
Comments
Do we want to make a separate issue for each component or just take it as we go? @Barsnes |
I'll try to complete this quest as soon as I have some time 🗡️🛡️ |
I think making a separate issue for each component is a bit overkill. |
Yeah, thinking the same, its just internal refactors anyways. |
After this we can also remove |
Added a list for to keep track of all the module files
|
Nice! @poi33 I updated the description with tasklist for each component we can check off when completed:) |
Much easier👍 Thanks |
No 😿, but one of you need to review the pull request for it and can mark it done that way. 🤷 |
Feedback changes from pull request
Feedback changes from pull request
We have prioritised this to Main quest! Due to planned changes in #1727 which will result in a lot of changes for our css, its best to do this first to avoid a heap of conflicts. So whoever has the time, create a draft PR for component x, check it in the list and get going! |
Sidequest whenever we have some spare time or we are in one of our components that has css defined as a
*.module.css
move it to separate.css
file if it doesn't require to much work.Actions
module.css
file topackages/css
and rename it to component name in lowercase.Button.module.css
->button.css
fds-
--fds-[component-name]
, like--fds-button-
clsx
with clsx/lite, i.e. don't use objects for classname string buildingbuild
to generate newreact-css-modules.css
file (to remove old css modules for component)Notes
refactor("component names"):
Combobox
for last due to lots of planned changes: fix(Combobox): Improve performance #1771Components:
Tasks
The text was updated successfully, but these errors were encountered: