Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(DropdownMenu): ♻️ Move styling to dropdownmenu.css #1946

Merged
merged 4 commits into from
May 7, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented May 6, 2024

#1846

Removes DropdownMenuItem.module.css and DropdownMenuGroup.module.css, and combines all of them in dropdownmenu.css - under the fds.dropdownmenu layer

@Barsnes Barsnes marked this pull request as ready for review May 6, 2024 06:09
@Barsnes Barsnes requested a review from mimarz as a code owner May 6, 2024 06:09
Copy link
Contributor

github-actions bot commented May 6, 2024

Preview deployments for this pull request:

📖 Storybook 7. May 2024 - 09:25 (Norwegian time)

See all deployments at https://dev.designsystemet.no

Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure here, I kinda like just fds-dropdown, but it might cause confusing as this component is called dropdownmenu everywhere else in the designsystem... I suggest keeping the original name and rather change it everywhere than just here.

@Barsnes Barsnes requested a review from mimarz May 7, 2024 06:34
@Barsnes Barsnes merged commit a2421d7 into main May 7, 2024
3 checks passed
@Barsnes Barsnes deleted the css/dropdownmenu branch May 7, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants