Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown.Heading API #2439

Closed
Barsnes opened this issue Sep 17, 2024 · 1 comment · Fixed by #2694
Closed

Dropdown.Heading API #2439

Barsnes opened this issue Sep 17, 2024 · 1 comment · Fixed by #2694
Assignees
@eirikbacker
Labels
css @digdir/designsystemet-css react @digdir/designsystemet-react
Milestone
V1 - Helhetlig ko...

Comments

@Barsnes
Copy link
Member

Barsnes commented Sep 17, 2024 •
edited
Loading

See discussion: #2432 (comment)

Er litt rart å ha en Heading, men at sizes følger Paragraph - at det ikke matcher med Heading-hierarkiet man kjenner igjen i Figma, men dette kan kanskje bli en egen oppgave.
Også litt rart å ikke kunne sette level. Tenker - dersom vi kaller noe *.Heading, burde det extende Heading-komponenten
@Barsnes Barsnes mentioned this issue Sep 17, 2024
Merged
@Barsnes Barsnes added ✨enhancement react @digdir/designsystemet-react css @digdir/designsystemet-css and removed ✨enhancement labels Sep 17, 2024
@mimarz mimarz changed the title DropdownMenu.Heading API Dropdown.Heading API Sep 24, 2024
@mimarz
Copy link
Collaborator

mimarz commented Sep 24, 2024 •
edited
Loading

I suggest Dropdown.Heading extends Heading.

Dropdown.Heading is just Heading with default props for use in the context of a Dropdown

What do you guys think? @eirikbacker @Barsnes

@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Sep 25, 2024
@mimarz mimarz closed this as completed Oct 17, 2024
@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Design System Oct 17, 2024
@mimarz mimarz reopened this Oct 17, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🔵 Inbox in Team Design System Oct 17, 2024
@eirikbacker eirikbacker self-assigned this Oct 28, 2024
@eirikbacker eirikbacker moved this from 📄 Todo to 🏗 In progress in Team Design System Oct 28, 2024
@eirikbacker eirikbacker mentioned this issue Oct 28, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Team Design System Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eirikbacker eirikbacker

Labels
css @digdir/designsystemet-css react @digdir/designsystemet-react
Projects
Team Design System
Status: ✅ Done
Milestone
V1 - Helhetlig komponentbibliotek
Development

Successfully merging a pull request may close this issue.

fix(Dropdown): extend Heading component and introduce Dropdown.Button digdir/designsystemet
3 participants
@eirikbacker @mimarz @Barsnes