feat(dropdownmenu): streamline API #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f0ccd07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - Storefront - Theme - |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
I am putting this in review, as I feel like I have done enough for this PR. |
eirikbacker
reviewed
Sep 17, 2024
packages/react/src/components/DropdownMenu/DropdownMenu.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/DropdownMenu/DropdownMenuContext.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/DropdownMenu/DropdownMenuHeading.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/DropdownMenu/DropdownMenuList.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/DropdownMenu/DropdownMenuItem.tsx
Outdated
Show resolved
Hide resolved
eirikbacker
approved these changes
Sep 17, 2024
Closed
|
We have decided to rename this to |
mimarz
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Looks good!
We need to have a closer look at the intended use for our outer .Context component as its not consistent with how its used in Popover and Dropdown. This goes against #2221
- We have a
Dropdown.Contextbut also an additional context (insideDropdown) that is the component context. - In
Popover, thePopover.Contextis the component context.
The way its used now is to add support for the .Trigger sub-component and not the actual component context.
We need to look closer at this as this will definitely cause confusion as to if its needed or not.
This will also affect Modal and Dialog.
mimarz
pushed a commit
that referenced
this pull request
Sep 20, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @digdir/[email protected] ### Patch Changes - Textarea: Use `field-sizing: content` ([#2463](#2463)) - ErrorSummary: Rename ErrorSummary.Root to ErrorSummary ([#2437](#2437)) - Tabs: ([#2448](#2448)) - Renames `Tabs.Root` to `Tabs` - Renames `Tabs.Content` to `Tabs.Panel` - Rename classes from `ds-error-message*` to `ds-validation-message*` ([#2473](#2473)) - Modal: css changes ([#2418](#2418)) - DropdownMenu: ([#2432](#2432)) - Rename from `DropdownMenu` to `Dropdown` - Change API and structure - Rename `.Root` to `.Context` - Rename `.Content` to `Dropdown` - Tabs: css changes ([#2431](#2431)) - ToggleGroup: Rename ToggleGroup.Root to ToggleGroup ([#2424](#2424)) - Badge: Only use single DOM element for rendering ([#2422](#2422)) - Skeleton: Replace Skeleton.Text, Skeleton.Circle and Skeleton.Rectangle with <Skeleton variant=""> ([#2435](#2435)) - Breadcrumbs: Rename `Breadcrumbs.Root` to `Breadcrumbs` and remove `Breadcrumbs.Nav` ([#2428](#2428)) - HelpText: ([#2438](#2438)) - Use Popover API - Remove `portal` prop - Render icon with pseudo element and require aria-label - Fieldset: Style using css attributes ([#2447](#2447)) ## @digdir/[email protected] ### Patch Changes - Correctly mark dependencies as external. This ensures Accordion works when consumers have enabled tree-shaking. ([#2479](#2479)) - Button: Remove `type` when `asChild={true}` ([#2472](#2472)) - ErrorSummary: Rename ErrorSummary.Root to ErrorSummary ([#2437](#2437)) - Tabs: ([#2448](#2448)) - Renames `Tabs.Root` to `Tabs` - Renames `Tabs.Content` to `Tabs.Panel` - Modal: css changes ([#2418](#2418)) - Rename `ErrorMessage` to `ValidationMessage` ([#2473](#2473)) - DropdownMenu: ([#2432](#2432)) - Rename from `DropdownMenu` to `Dropdown` - Change API and structure - Rename `.Root` to `.Context` - Rename `.Content` to `Dropdown` - Tabs: css changes ([#2431](#2431)) - ToggleGroup: Rename ToggleGroup.Root to ToggleGroup ([#2424](#2424)) - Badge: Only use single DOM element for rendering ([#2422](#2422)) - Skeleton: Replace Skeleton.Text, Skeleton.Circle and Skeleton.Rectangle with <Skeleton variant=""> ([#2435](#2435)) - Breadcrumbs: Rename `Breadcrumbs.Root` to `Breadcrumbs` and remove `Breadcrumbs.Nav` ([#2428](#2428)) - HelpText: ([#2438](#2438)) - Use Popover API - Remove `portal` prop - Render icon with pseudo element and require aria-label - Fieldset: Style using css attributes ([#2447](#2447)) ## @digdir/[email protected] ## @digdir/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2221
I changed to using our
Popover, which means we can handle testing state there.New API is this: