Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tokens): 👷 Build & commit generated tokens on PR #1243

Merged
merged 15 commits into from
Dec 19, 2023

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Dec 19, 2023

resolves #1118

Should work as intended but we don't have any changes to tokens that trigger a diff currently :)

Tested changing values in Altinn.json which triggered a new build & commit, see: ad74991

This also triggered new preview builds for Storybook & Storefront which is good :D

Copy link
Contributor

github-actions bot commented Dec 19, 2023

Preview deployments for this pull request:

📖 Storybook 19. Dec 2023 - 10:15 (Norwegian time)

🖥 Storefront 19. Dec 2023 - 10:15 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@mimarz mimarz marked this pull request as ready for review December 19, 2023 08:37
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to test this, so I'll approve this in good faith 🚀

@mimarz mimarz merged commit f0d4a18 into main Dec 19, 2023
@mimarz mimarz deleted the ci/build-tokens-commit branch December 19, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow for building tokens in PR
2 participants