feat(Paragraph): Add variant prop with long and short

[Barsnes]

Resolves #1476

This PR deprecates short, and users will now use variant to set short or long.

short will be removed in #1702

[github-actions]

Preview deployments for this pull request:

📖 Storybook 18. Mar 2024 - 10:43 (Norwegian time)

🖥 Storefront 18. Mar 2024 - 10:44 (Norwegian time)

See all deployments at https://dev.designsystemet.no

[mimarz]

Hmm, curious if we should just introduce a lineHeight prop with default, short, long as options and just mark short for deprecation. Would make it more clear they are mutually exclusive. What do you think @Barsnes ?

[Barsnes]

Hmm, curious if we should just introduce a lineHeight prop with default, short, long as options and just mark short for deprecation. Would make it more clear they are mutually exclusive. What do you think @Barsnes ?

I don't think we should, since line-height is a prop in css, users might think they can send any value in here.
variant, or something along those lines would be better, I think 🤔

[mimarz]

Hmm, curious if we should just introduce a lineHeight prop with default, short, long as options and just mark short for deprecation. Would make it more clear they are mutually exclusive. What do you think @Barsnes ?

I don't think we should, since line-height is a prop in css, users might think they can send any value in here. variant, or something along those lines would be better, I think 🤔

hmm, we already have weight on Label which kinda acts the same, expect its just a suggested subset of the actual values for font-weight 🤔

I kinda dont think we should use variant for this as its what we normaly use to denote primary, secondary, tertiary variants for our components.

Hmm, any other suggestions for names? Or we just keep it long and short...

[Barsnes]

Hmm, curious if we should just introduce a lineHeight prop with default, short, long as options and just mark short for deprecation. Would make it more clear they are mutually exclusive. What do you think @Barsnes ?

I don't think we should, since line-height is a prop in css, users might think they can send any value in here. variant, or something along those lines would be better, I think 🤔

hmm, we already have weight on Label which kinda acts the same, expect its just a suggested subset of the actual values for font-weight 🤔

I kinda dont think we should use variant for this as its what we normaly use to denote primary, secondary, tertiary variants for our components.

Hmm, any other suggestions for names? Or we just keep it long and short...

If we can't think of anything better I suggest we keep it as long and short - and we can look into this further later 😄

[mimarz]

Hmm, curious if we should just introduce a lineHeight prop with default, short, long as options and just mark short for deprecation. Would make it more clear they are mutually exclusive. What do you think @Barsnes ?

I don't think we should, since line-height is a prop in css, users might think they can send any value in here. variant, or something along those lines would be better, I think 🤔

hmm, we already have weight on Label which kinda acts the same, expect its just a suggested subset of the actual values for font-weight 🤔
I kinda dont think we should use variant for this as its what we normaly use to denote primary, secondary, tertiary variants for our components.
Hmm, any other suggestions for names? Or we just keep it long and short...

If we can't think of anything better I suggest we keep it as long and short - and we can look into this further later 😄

variant is also used in Figma so what the heck, lets use that. Better than having two props which are mutually exclusive.

[mimarz]

Should we maybe add default so it matches the behaviour of our other variant props? It won't do anything but would make life easier for projects like Studio where user can select these props. 🤔

[Barsnes]

hm not sure 🤔 It won't hurt to add it, since it does not do anything - your call 😃

[mimarz]

We decided to go for variant.

[mimarz]

In reality we have three different line height. We didn't add a default option in variant as the "default" line-height is backed into the variable used for font and it might be changed with static typography. We will add the third option later when the dust has settled for that. #1707

[mimarz]

LGTM 👍

Added an issue so we remember to the "missing"/default line-height in the future #1707