Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Combobox): Improve performance #1771

Merged
merged 53 commits into from
May 13, 2024
Merged

fix(Combobox): Improve performance #1771

merged 53 commits into from
May 13, 2024

Commits on Apr 23, 2024

  1. fix(Combobox): Re-renders

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    24fa39f View commit details
    Browse the repository at this point in the history

  2. some more optimizations

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1f2a6b4 View commit details
    Browse the repository at this point in the history

  3. options as object to lookup faster

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    76a741c View commit details
    Browse the repository at this point in the history

  4. update tests, some misc

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2c9be2a View commit details
    Browse the repository at this point in the history

  5. selectedOptions is an array

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b5fdded View commit details
    Browse the repository at this point in the history

  6. build errors

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3c69ad5 View commit details
    Browse the repository at this point in the history

  7. add consolelogs to figure out why options renders so much

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    98d44be View commit details
    Browse the repository at this point in the history

  8. misc work for options and lookup

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b81e9a7 View commit details
    Browse the repository at this point in the history

  9. more console logs, add useComboboxOption

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    18d87f2 View commit details
    Browse the repository at this point in the history

  10. move filter to useCombobox

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    5e266d2 View commit details
    Browse the repository at this point in the history

  11. more hooks (remember; add reducer to context)

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a9de233 View commit details
    Browse the repository at this point in the history

  12. activeIndex working

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b5776a0 View commit details
    Browse the repository at this point in the history

  13. fix keydown Enter

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    45d086c View commit details
    Browse the repository at this point in the history

  14. add missing test for enter

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e746f30 View commit details
    Browse the repository at this point in the history

  15. keyboard func hook

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e3a4e08 View commit details
    Browse the repository at this point in the history

  16. start with adding context

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    955e8f7 View commit details
    Browse the repository at this point in the history

  17. more work on context, and moving around

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    69236f4 View commit details
    Browse the repository at this point in the history

  18. fix keyboard navigation

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9f228e2 View commit details
    Browse the repository at this point in the history

  19. more keyboard

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b7f24f9 View commit details
    Browse the repository at this point in the history

  20. more keyboard that comes from listnav

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    03a6d50 View commit details
    Browse the repository at this point in the history

  21. refactor active descendant

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4dffec5 View commit details
    Browse the repository at this point in the history

  22. more list optimization

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1ffac0b View commit details
    Browse the repository at this point in the history

  23. remove console logs, cleanup

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    32c402c View commit details
    Browse the repository at this point in the history

  24. more options on story

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    dc91645 View commit details
    Browse the repository at this point in the history

  25. fix custom children

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6c8e829 View commit details
    Browse the repository at this point in the history

  26. refactor filtering

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3fb48b1 View commit details
    Browse the repository at this point in the history

  27. fix build errors

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1009446 View commit details
    Browse the repository at this point in the history

  28. typescript enchancement

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e12537d View commit details
    Browse the repository at this point in the history

  29. fix length check

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7053ef2 View commit details
    Browse the repository at this point in the history

  30. fix build error, update floating-ui

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a51278b View commit details
    Browse the repository at this point in the history

  31. check length equal or greater than 0

    @Barsnes
    Barsnes committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ab8232d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Publish 

     - @digdir/[email protected]
 - @digdir/[email protected]
 - @digdir/[email protected]
    @mimarz
    mimarz committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    0006fe3 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. only run children once

    @Barsnes
    Barsnes committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8e2e8eb View commit details
    Browse the repository at this point in the history

  2. reducer for children

    @Barsnes
    Barsnes committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ca44956 View commit details
    Browse the repository at this point in the history

  3. early returns

    @Barsnes
    Barsnes committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b3defbe View commit details
    Browse the repository at this point in the history

  4. fix single input reset

    @Barsnes
    Barsnes committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    40b8216 View commit details
    Browse the repository at this point in the history

  5. types

    @Barsnes
    Barsnes committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    cff4b8b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into test-fix/combobox

    @Barsnes
    Barsnes authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    368ac9e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into test-fix/combobox

    @Barsnes
    Barsnes authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8481123 View commit details
    Browse the repository at this point in the history

  8. remove old prop

    @Barsnes
    Barsnes committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    3bbb62d View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge branch 'main' into test-fix/combobox

    @Barsnes
    Barsnes authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b1f4458 View commit details
    Browse the repository at this point in the history

  2. Remove focus state from ComboboxInput

    @Barsnes
    Barsnes committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    226fc5e View commit details
    Browse the repository at this point in the history

  3. remove duplicate code

    @Barsnes
    Barsnes committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c60908d View commit details
    Browse the repository at this point in the history

  4. rework handle value changing

    @Barsnes
    Barsnes committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    43ead37 View commit details
    Browse the repository at this point in the history

  5. move props, and remove unused

    @Barsnes
    Barsnes committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a8d7c59 View commit details
    Browse the repository at this point in the history

  6. some more work on props

    @Barsnes
    Barsnes committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a3debda View commit details
    Browse the repository at this point in the history

  7. remove console logs

    @Barsnes
    Barsnes committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    00619b1 View commit details
    Browse the repository at this point in the history

  8. built css

    @mimarz
    mimarz committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7dd6017 View commit details
    Browse the repository at this point in the history

  9. Publish 

     - @digdir/[email protected]
 - @digdir/[email protected]
 - @digdir/[email protected]
    @mimarz
    mimarz committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7e9e9ba View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'main' into test-fix/combobox

    @Barsnes
    Barsnes authored May 7, 2024
    Configuration menu
    Copy the full SHA
    f44dc06 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into test-fix/combobox

    @mimarz
    mimarz authored May 7, 2024
    Configuration menu
    Copy the full SHA
    4a1886b View commit details
    Browse the repository at this point in the history

  3. fix closed when typing

    @Barsnes
    Barsnes committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1031476 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'main' into test-fix/combobox

    @Barsnes
    Barsnes authored May 8, 2024
    Configuration menu
    Copy the full SHA
    1f8b784 View commit details
    Browse the repository at this point in the history