Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storefront): Fix smaller MDX styling issues #1926

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

Thunear
Copy link
Collaborator

@Thunear Thunear commented May 2, 2024

resolves #1912
resolves #1911
resolves #1921

Width of videos: Added a CSS variable to set max-width on media elements. Added this to the ResponsiveIframe component that is used to show videos. /grunnleggende/for-designere/kom-i-gang has a video

Lists wider than paragraph: Added ul and ol tags to the same width as paragraphs.

Code inside lists: Added styling of the code tag to ul and ol lists.

Copy link
Contributor

github-actions bot commented May 2, 2024

Preview deployments for this pull request:

🖥 Storefront 2. May 2024 - 11:29 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Thunear Thunear changed the title Added 800px max width to responsiveIframe Storefront: Fix smaller MDX styling issues May 2, 2024
@Thunear Thunear changed the title Storefront: Fix smaller MDX styling issues chore(storefront): Fix smaller MDX styling issues May 2, 2024
@Thunear Thunear marked this pull request as ready for review May 2, 2024 09:30
@Barsnes
Copy link
Member

Barsnes commented May 2, 2024

You need to write resolves #ISSUE for every issue you want this PR to close

@Thunear
Copy link
Collaborator Author

Thunear commented May 2, 2024

You need to write resolves #ISSUE for every issue you want this PR to close

Good to know, changed it.

@mimarz mimarz merged commit 9294da4 into main May 3, 2024
8 checks passed
@mimarz mimarz deleted the fix/storfront-styling branch May 3, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List is wider than paragraph Videos is wider than images Coded elements have no styling inside lists
3 participants