Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): rename from nativeselect #2404

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

eirikbacker
Copy link
Contributor

Fixes #2399

Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: fb93f93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-css Patch
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch
@digdir/designsystemet-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Preview deployments for this pull request:

📖 Storybook 12. Sep 2024 - 21:35 (Norwegian time)

🖥 Storefront 12. Sep 2024 - 21:36 (Norwegian time)

See all deployments at https://dev.designsystemet.no

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 63.79% 4598 / 7207
🔵 Statements 63.79% 4598 / 7207
🔵 Functions 85.54% 148 / 173
🔵 Branches 75.61% 586 / 775
File CoverageNo changed files found.
Generated in workflow #258

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Preview deployments

Theme 12. Sep 2024 - 21:35 (Norwegian time)

@eirikbacker eirikbacker merged commit 9220945 into next Sep 13, 2024
8 checks passed
@eirikbacker eirikbacker deleted the fix/nativeselect-to-select branch September 13, 2024 08:04
mimarz pushed a commit that referenced this pull request Sep 17, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/[email protected]

### Patch Changes

- Pagination: Use data attrs instead of class names
([#2395](#2395))

- Badge: Style using css attributes
([#2391](#2391))

- TableHeaderCell: Remove `sortable` prop, `sort` now handles this
([#2393](#2393))

- dropdownmenu: Style using data attributes
([#2387](#2387))

- Chip: Text color is now `accent`
([#2371](#2371))

- List: Remove `List.Root` and `List.Heading`, which changes API
([#2348](#2348))

- Alert, Avatar, Button, Divider, Link: Use data-attributes for variant,
size and color and move icons to CSS
([#2313](#2313))

- Box: Remove component
([#2372](#2372))

- Popover: ([#2369](#2369))

    -   Rename `<Popover.Root>` to `<Popover.Context>`
- use Popover API, allowing `<Popover>` to be used without
`Popover.Context`
    -   Remove `portal` prop

- Tooltip: Only expose background css variable
([#2389](#2389))

- Switch: don't show check when not checked in readonly
([#2377](#2377))

- Select: Rename from `NativeSelect`
([#2404](#2404))

- Accordion: Now uses details and summary HTML elements
([`5d1c5062b526e6829c322ce66c6df08568bb9f63`](5d1c506))

- Spinner: Style using data attributes
([#2390](#2390))

- Avatar: new component
([#2312](#2312))

- Tag: Make neutral default color in CSS
([#2397](#2397))

- Card: Use data attrs
([#2398](#2398))

## @digdir/[email protected]

### Patch Changes

- Pagination: Use data attrs instead of class names
([#2395](#2395))

- Badge: Style using css attributes
([#2391](#2391))

- TableHeaderCell: Remove `sortable` prop, `sort` now handles this
([#2393](#2393))

- dropdownmenu: Style using data attributes
([#2387](#2387))

- List: Remove `List.Root` and `List.Heading`, which changes API
([#2348](#2348))

- Alert, Avatar, Button, Divider, Link: Use data-attributes for variant,
size and color and move icons to CSS
([#2313](#2313))

- Box: Remove component
([#2372](#2372))

- Popover: ([#2369](#2369))

    -   Rename `<Popover.Root>` to `<Popover.Context>`
- use Popover API, allowing `<Popover>` to be used without
`Popover.Context`
    -   Remove `portal` prop

- Select: Rename from `NativeSelect`
([#2404](#2404))

- Table: Set sort button type to prevent form submit
([#2402](#2402))

- Heading: default level is now 2
([#2378](#2378))

- Select: ([#2415](#2415))

    -   Add Select.Option and Select.Optgroup compond components
    -   Remove `multiple` prop

- Accordion: Now uses details and summary HTML elements
([`5d1c5062b526e6829c322ce66c6df08568bb9f63`](5d1c506))

- Spinner: Style using data attributes
([#2390](#2390))

- Avatar: new component
([#2312](#2312))

- Tag: Make neutral default color in CSS
([#2397](#2397))

- Card: Use data attrs
([#2398](#2398))

- Combobox: fix virtual combobox having large gap between items
([#2376](#2376))

## @digdir/[email protected]



## @digdir/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename NativeSelect to Select
2 participants