Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔥 Remove autogenerated typography classes #2429

Merged
merged 14 commits into from
Sep 19, 2024

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Sep 17, 2024

resolves #2392

  • Removed typography in name from typography CSS variables (This touched a lot of files).
  • Removed generated CSS classes.
    • Replaced with deconstructed CSS variable for each prop.
  • Replicated current classes with new CSS variables to make sure everything was still working.
  • ⚠️ Paragraph typography variants, short & long needs to be separate classes to support @composes as it colides with other components variant.
    • For example Button variant.
    • I would think this is a minor tradeoff.
  • Saving rewrite of typography classes to new CSS convention for separate PR as this is big enough.
  • Concatenated base layer with utilities and typography

Look at "old" changes in commit 2e0c899 on how Button and Paragraph can be updated to follow the new convention.

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: 93cbe2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 17, 2024

Preview deployments for this pull request:

Storybook - 19. Sep 2024 - 08:49

Storefront - 19. Sep 2024 - 08:51

Copy link
Contributor

github-actions bot commented Sep 17, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 62.38% 4340 / 6957
🔵 Statements 62.38% 4340 / 6957
🔵 Functions 86.73% 170 / 196
🔵 Branches 75.52% 574 / 760
File CoverageNo changed files found.
Generated in workflow #501

@mimarz mimarz force-pushed the chore-remove-autogenerated-typography-classes branch from b9e5f3a to 6d26b31 Compare September 17, 2024 09:54
@mimarz mimarz marked this pull request as ready for review September 18, 2024 09:34
@mimarz
Copy link
Collaborator Author

mimarz commented Sep 18, 2024

We'll make a separate PR into this one for updating the rest of the typography classes and @composes as the typography styling is currently broken.

Edit: Reverted the changes to Button & Paragraph so that this change is backwards compatible now. 2e0c899

We can continue the work in other PRs.

Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mimarz mimarz force-pushed the chore-remove-autogenerated-typography-classes branch from 2e0c899 to 93cbe2b Compare September 19, 2024 06:47
@mimarz mimarz merged commit c3f9e92 into next Sep 19, 2024
7 checks passed
@mimarz mimarz deleted the chore-remove-autogenerated-typography-classes branch September 19, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace auto-generated typography classes with CSS variables
3 participants