-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🔥 Remove autogenerated typography classes #2429
Conversation
|
Preview deployments for this pull request: Storybook - Storefront - |
Coverage Report
File CoverageNo changed files found. |
b9e5f3a
to
6d26b31
Compare
packages/react/src/components/Typography/Paragraph/Paragraph.tsx
Outdated
Show resolved
Hide resolved
We'll make a separate PR into this one for updating the rest of the typography classes and Edit: Reverted the changes to We can continue the work in other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
2e0c899
to
93cbe2b
Compare
resolves #2392
typography
in name from typography CSS variables (This touched a lot of files).short
&long
needs to be separate classes to support@composes
as it colides with other componentsvariant
.Button
variant
.base
layer withutilities
andtypography
Look at "old" changes in commit 2e0c899 on how
Button
andParagraph
can be updated to follow the new convention.