Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): only set aria-controls when open, fix reference id to list #2575

Closed
wants to merge 5 commits into from

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Oct 7, 2024

DO NOT MERGE THIS TO MAIN

This has been synced in our next branch with PR ##2576

resolves #2552

This solves the issue by not adding aria-controls until the popup is visible (and in the DOM).
This also makes use of floating uis internal id, so the id is also correct.

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: f8d3cb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Preview deployments for this pull request:

📖 Storybook 8. Oct 2024 - 10:37 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review October 7, 2024 10:26
@Barsnes Barsnes requested a review from mimarz as a code owner October 7, 2024 10:26
@Barsnes
Copy link
Member Author

Barsnes commented Oct 7, 2024

Setting this as ready for review, but will not be merging when approved.
After approval a release for version 0.63.1 will be done

@Barsnes Barsnes changed the title fix(combobox): only set aria-controls when open fix(combobox): only set aria-controls when open, fix reference id to list Oct 7, 2024
Copy link
Contributor

@eirikbacker eirikbacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Magnusrm
Copy link
Contributor

Magnusrm commented Oct 8, 2024

Tested this branch with ARC toolkit and the error is no longer reported. I have not tested using a JAWS screen-reader though, as i dont have a license. 😅
(Edit: VoiceOver seems to work fine atleast)

@Barsnes
Copy link
Member Author

Barsnes commented Oct 8, 2024

Great! I'll fix the storybook deployment and get a release going

Barsnes added a commit that referenced this pull request Oct 8, 2024
this PR is only to reflect changes made in an older version in PR #2575
unekinn pushed a commit that referenced this pull request Oct 10, 2024
this PR is only to reflect changes made in an older version in PR #2575
unekinn pushed a commit that referenced this pull request Oct 11, 2024
this PR is only to reflect changes made in an older version in PR #2575
@mimarz
Copy link
Collaborator

mimarz commented Nov 1, 2024

Closing PR but not deleting branch

@mimarz mimarz closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants