-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combobox): only set aria-controls
when open, fix reference id to list
#2575
Conversation
|
Preview deployments for this pull request: 📖 Storybook See all deployments at https://dev.designsystemet.no |
Setting this as ready for review, but will not be merging when approved. |
aria-controls
when openaria-controls
when open, fix reference id to list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Tested this branch with ARC toolkit and the error is no longer reported. I have not tested using a JAWS screen-reader though, as i dont have a license. 😅 |
Great! I'll fix the storybook deployment and get a release going |
this PR is only to reflect changes made in an older version in PR #2575
this PR is only to reflect changes made in an older version in PR #2575
this PR is only to reflect changes made in an older version in PR #2575
Closing PR but not deleting branch |
DO NOT MERGE THIS TO MAIN
This has been synced in our next branch with PR ##2576
resolves #2552
This solves the issue by not adding
aria-controls
until the popup is visible (and in the DOM).This also makes use of floating uis internal id, so the id is also correct.