Skip to content

chore: themebuilder redesign#2740

Merged
mimarz merged 63 commits intonextfrom
chore/themebuilder-v2
Dec 9, 2024
Merged

chore: themebuilder redesign#2740
mimarz merged 63 commits intonextfrom
chore/themebuilder-v2

Conversation

@Thunear
Copy link
Collaborator

@Thunear Thunear commented Nov 5, 2024 •
edited
Loading

Started prototyping and testing the new design in code. I want to first add the functionality for colors and then have people in the team test the flow. Then when the flow is good implement the rest of the design.

Resolves #2684

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fe30312

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Preview deployments for this pull request:

Theme - 9. Dec 2024 - 15:55

@Thunear Thunear changed the title chore: Themebuilder redesign chore: themebuilder redesign Nov 11, 2024
@Thunear Thunear self-assigned this Nov 11, 2024
@Barsnes Barsnes marked this pull request as ready for review December 9, 2024 08:58
@Barsnes
Copy link
Member

Barsnes commented Dec 9, 2024

CodeSnippet throws an error on formatting, but this is not an issue in Temabyggeren - and does not stop any build from working.
The snippet is still displayed, just without being formatted

mimarz
mimarz approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many changes in code 😵

Just tested the actual site to see if everything worked as intended. Looked good 👍

@mimarz mimarz merged commit 9c86671 into next Dec 9, 2024
@mimarz mimarz deleted the chore/themebuilder-v2 branch December 9, 2024 14:59
mimarz pushed a commit that referenced this pull request Feb 21, 2025
@Thunear @Barsnes @mimarz
chore: themebuilder redesign (#2740)
05442a7 
Started prototyping and testing the new design in code. I want to first
add the functionality for colors and then have people in the team test
the flow. Then when the flow is good implement the rest of the design.

Resolves #2684

---------

Co-authored-by: Barsnes <tobias.barsnes@digdir.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimarz mimarz mimarz approved these changes

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes is a code owner

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

@unekinn unekinn Awaiting requested review from unekinn

Assignees

@Thunear Thunear

Labels

None yet

Projects

Team Designsystemet
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Themebuilder design for v1

3 participants

@Thunear @Barsnes @mimarz