Skip to content

Conversation

johannegg
Copy link
Collaborator

@johannegg johannegg commented Jul 28, 2025

Changes done in this pr:

  • Made the fullscreen image overlay its own component and it is now rendering outside the main container, so that it can be placed in front over the headercontainer. This also solved the problem of the cross out button not being visible

  • Changed the styling of the preview images in the input field

    • image
  • Added fullscreen functionality to preview images as well.

  • Made the email link in the helper text work again by moving helpertext to ChatInput.tsx and make the buttons class smaller, so that it is not in front of the helper text.

  • Fixed the logo link to match brukerstotte vs servicedesk

  • Added margin-bottom to the chatloader in order for it to still be visible after the page has scrolled.

Something I tried

image I tried adding a checkerboard background to highlight transparent images, but felt that it was a bit ugly. I am however open to adding it back 😅. Could also potentially add it to the fullscreen overlay

To do next in order:

  • Translate all text that is not translated yet
  • Switch to brukerstotte mail when on brukerstotte
  • Make the image error message a popup
  • Fix the color of the text in the dropdown menues
  • Make the logo in the ChatbotPage a bit smaller

@johannegg johannegg self-assigned this Jul 28, 2025
@johannegg johannegg added the bug Something isn't working label Jul 28, 2025
@johannegg johannegg linked an issue Jul 28, 2025 that may be closed by this pull request
3 tasks
@johannegg johannegg changed the title Bug: fix image close button Bug: fix image close button ++ Jul 28, 2025
@johannegg johannegg marked this pull request as ready for review July 29, 2025 08:17
Copy link
Contributor

@vegardaaalbretsen vegardaaalbretsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🥇

image This was kinda weird, but i am not sure if it is better with the checkerboard...

@johannegg johannegg merged commit 4e23cf9 into dev Jul 29, 2025
2 checks passed
@johannegg johannegg deleted the 55-bug-fix-image-close-button branch July 29, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix image close button

2 participants