Skip to content

Feat/return errors #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 21, 2025
Merged

Feat/return errors #117

merged 9 commits into from
May 21, 2025

Conversation

syedhasandigi
Copy link
Contributor

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Feature

Linked tickets

https://digicatapult.atlassian.net/browse/NIDT-123

High level description

dtdlParser now returns an error object instead of null for a failed parse

Detailed description

Function dtdlParser will return a ModelingException instead of null, type is now
DtdlObjectModel | ModelingException

Operational impact

Consumption in the dtdl-visualsation-tool where null is handled must be updated to handle ModelingException

@syedhasandigi syedhasandigi requested a review from a team as a code owner May 19, 2025 12:37
@syedhasandigi syedhasandigi requested a review from jonmattgray May 20, 2025 07:42
@syedhasandigi syedhasandigi merged commit 6d7607c into main May 21, 2025
8 checks passed
@syedhasandigi syedhasandigi deleted the feat/return-errors branch May 21, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants