Skip to content

VR 405 - logging#332

Merged
rmlearney-digicatapult merged 30 commits intomainfrom
VR-405
Jul 28, 2025
Merged

VR 405 - logging#332
rmlearney-digicatapult merged 30 commits intomainfrom
VR-405

Conversation

@rmlearney-digicatapult
Copy link
Contributor

@rmlearney-digicatapult rmlearney-digicatapult commented Jul 24, 2025

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix

Linked tickets

https://digicatapult.atlassian.net/browse/VR-405

High level description

Fix empty log messages, removed duplicate logging, swapped to pino-pretty for local dev

Detailed description

Use string interpolation in internal error handlers Error('${err}'), removed duplicate log entries where we were passing a cli log.warn('message') and a throw new Error('message') at the same time

Switched to pino-pretty for cli dev

Describe alternatives you've considered

Operational impact

Additional context

@rmlearney-digicatapult rmlearney-digicatapult marked this pull request as ready for review July 28, 2025 08:55
@rmlearney-digicatapult rmlearney-digicatapult requested a review from a team as a code owner July 28, 2025 08:55
@rmlearney-digicatapult rmlearney-digicatapult merged commit 4043462 into main Jul 28, 2025
9 checks passed
@rmlearney-digicatapult rmlearney-digicatapult deleted the VR-405 branch July 28, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments