Skip to content

VR 405 - logging #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

VR 405 - logging #332

wants to merge 18 commits into from

Conversation

rmlearney-digicatapult
Copy link
Contributor

@rmlearney-digicatapult rmlearney-digicatapult commented Jul 24, 2025

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix

Linked tickets

https://digicatapult.atlassian.net/browse/VR-405

High level description

Fix empty log messages, removed duplicate logging, swapped to pino-pretty for local dev

Detailed description

Use string interpolation in internal error handlers Error('${err}'), removed duplicate log entries where we were passing a cli log.warn('message') and a throw new Error('message') at the same time

Switched to pino-pretty for cli dev

Describe alternatives you've considered

Operational impact

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant