chore: upgrade eslint configuration #897
Conversation
achou11
force-pushed
the
ac/upgrade-eslint
branch
from
cbf782a to
4994618
Compare
|
| Status | Count |
|---|---|
| 59 | |
| 236 | |
| 27 | |
| 73 |
Click to toggle table visibility
| Name | Status | Previous | Current |
|---|---|---|---|
@aashutoshrathi/word-wrap |
1.2.6 | - | |
@ampproject/remapping |
2.2.0 | 2.3.0 | |
@babel/eslint-parser |
7.26.5 | - | |
@babel/highlight |
7.25.7 | 7.25.9 | |
@babel/plugin-syntax-class-static-block |
- | 7.14.5 | |
@babel/plugin-syntax-private-property-in-object |
- | 7.14.5 | |
@babel/plugin-transform-runtime |
7.25.9 | 7.26.8 | |
@babel/plugin-transform-typescript |
7.26.5 | 7.26.8 | |
@babel/preset-flow |
7.23.3 | 7.25.9 | |
@babel/register |
7.23.7 | 7.25.9 | |
@babel/traverse--for-generate-function-map |
7.26.5 | 7.26.8 | |
@emnapi/core |
- | 1.3.1 | |
@emnapi/runtime |
- | 1.3.1 | |
@emnapi/wasi-threads |
- | 1.0.1 | |
@eslint-community/eslint-utils |
4.4.0 | 4.4.1 | |
@eslint-react/ast |
- | 1.27.0 | |
@eslint-react/core |
- | 1.27.0 | |
@eslint-react/eff |
- | 1.27.0 | |
@eslint-react/eslint-plugin |
- | 1.27.0 | |
@eslint-react/jsx |
- | 1.27.0 | |
@eslint-react/shared |
- | 1.27.0 | |
@eslint-react/var |
- | 1.27.0 | |
@eslint/compat |
- | 1.2.7 | |
@eslint/config-array |
- | 0.19.2 | |
@eslint/core |
- | 0.12.0 | |
@eslint/eslintrc |
2.1.2 | 3.3.0 | |
@eslint/js |
8.47.0 | 9.21.0 | |
@eslint/object-schema |
- | 2.1.6 | |
@eslint/plugin-kit |
- | 0.2.7 | |
@expo/config-plugins |
9.0.14 | 9.0.15 | |
@expo/config-types |
52.0.3 | 52.0.4 | |
@expo/config |
10.0.8 | 10.0.9 | |
@expo/fingerprint |
- | 0.11.7 | |
@expo/prebuild-config |
8.0.25 | 8.0.26 | |
@expo/vector-icons |
14.0.0 | 14.0.4 | |
@faker-js/faker |
9.3.0 | 9.4.0 | |
@humanfs/core |
- | 0.19.1 | |
@humanfs/node |
- | 0.16.6 | |
@humanwhocodes/config-array |
0.11.10 | - | |
@humanwhocodes/object-schema |
1.2.1 | - | |
@humanwhocodes/retry |
- | 0.4.2 | |
@hyperswarm/secret-stream |
6.6.4 | 6.7.1 | |
@jest/create-cache-key-function |
29.6.3 | 29.7.0 | |
@jest/types |
26.6.2 | 29.6.3 | |
@jridgewell/gen-mapping |
0.1.1 | 0.3.8 | |
@jridgewell/resolve-uri |
3.1.0 | 3.1.2 | |
@jridgewell/source-map |
0.3.5 | 0.3.6 | |
@napi-rs/wasm-runtime |
- | 0.2.6 | |
@nicolo-ribaudo/eslint-scope-5-internals |
5.1.1-v1 | - | |
@node-rs/crc32-android-arm-eabi |
- | 1.10.6 | |
@node-rs/crc32-android-arm64 |
- | 1.10.6 | |
@node-rs/crc32-darwin-arm64 |
- | 1.10.6 | |
@node-rs/crc32-darwin-x64 |
1.10.4 | 1.10.6 | |
@node-rs/crc32-freebsd-x64 |
- | 1.10.6 | |
@node-rs/crc32-linux-arm-gnueabihf |
- | 1.10.6 | |
@node-rs/crc32-linux-arm64-gnu |
- | 1.10.6 | |
@node-rs/crc32-linux-arm64-musl |
- | 1.10.6 | |
@node-rs/crc32-linux-x64-gnu |
- | 1.10.6 | |
@node-rs/crc32-linux-x64-musl |
- | 1.10.6 | |
@node-rs/crc32-wasm32-wasi |
- | 1.10.6 | |
@node-rs/crc32-win32-arm64-msvc |
- | 1.10.6 | |
@node-rs/crc32-win32-ia32-msvc |
- | 1.10.6 | |
@node-rs/crc32-win32-x64-msvc |
- | 1.10.6 | |
@node-rs/crc32 |
1.10.4 | 1.10.6 | |
@npmcli/agent |
2.2.1 | 2.2.2 | |
@react-native-community/cli-debugger-ui |
12.3.6 | - | |
@react-native-community/cli-server-api |
12.3.6 | - | |
@react-native-community/cli-tools |
12.3.6 | - | |
@react-native/eslint-config |
0.76.6 | - | |
@react-native/eslint-plugin |
0.76.6 | - | |
@react-native/normalize-colors |
0.76.6 | 0.76.7 | |
@sinclair/typebox |
0.27.8 | 0.33.22 | |
@tanstack/eslint-plugin-query |
5.51.15 | 5.66.1 | |
@tybys/wasm-util |
- | 0.9.0 | |
@types/b4a |
1.6.3 | 1.6.4 | |
@types/babel__core |
7.20.1 | 7.20.5 | |
@types/babel__generator |
7.6.4 | 7.6.8 | |
@types/babel__template |
7.4.1 | 7.4.4 | |
@types/babel__traverse |
7.20.1 | 7.20.6 | |
@types/better-sqlite3 |
7.6.6 | 7.6.12 | |
@types/hammerjs |
2.0.41 | 2.0.46 | |
@types/hoist-non-react-statics |
3.3.1 | 3.3.6 | |
@types/istanbul-lib-coverage |
2.0.4 | 2.0.6 | |
@types/istanbul-lib-report |
3.0.0 | 3.0.3 | |
@types/istanbul-reports |
3.0.1 | 3.0.4 | |
@types/json-schema |
7.0.11 | 7.0.15 | |
@types/lodash |
4.14.199 | 4.17.15 | |
@types/ms |
0.7.34 | 2.1.0 | |
@types/prop-types |
15.7.5 | 15.7.14 | |
@types/react-native |
0.70.6 | 0.70.19 | |
@types/stack-utils |
2.0.1 | 2.0.3 | |
@types/streamx |
2.9.3 | 2.9.5 | |
@types/yargs-parser |
21.0.0 | 21.0.3 | |
@types/yargs |
15.0.14 | 17.0.33 | |
@typescript-eslint/eslint-plugin |
5.62.0 | 8.25.0 | |
@typescript-eslint/parser |
5.62.0 | 8.25.0 | |
@typescript-eslint/scope-manager |
5.62.0 | 8.25.0 | |
@typescript-eslint/type-utils |
5.62.0 | 8.25.0 | |
@typescript-eslint/types |
5.62.0 | 8.25.0 | |
@typescript-eslint/typescript-estree |
5.62.0 | 8.25.0 | |
@typescript-eslint/utils |
5.62.0 | 8.25.0 | |
@typescript-eslint/visitor-keys |
5.62.0 | 8.25.0 | |
@wdio/cli |
9.9.0 | 9.8.0 | |
@wdio/config |
9.9.0 | 9.7.3 | |
@wdio/utils |
9.9.0 | 9.7.3 | |
ansi-styles |
4.3.0 | 5.2.0 | |
anymatch |
3.1.2 | 3.1.3 | |
appdirsjs |
1.2.7 | - | |
argparse |
1.0.10 | 2.0.1 | |
array-buffer-byte-length |
1.0.1 | - | |
array-includes |
3.1.5 | - | |
array.prototype.flatmap |
1.3.0 | - | |
arraybuffer.prototype.slice |
1.0.3 | - | |
ast-types |
0.15.2 | 0.13.4 | |
b4a |
1.6.6 | 1.6.7 | |
babel-preset-current-node-syntax |
1.0.1 | 1.1.0 | |
babel-preset-expo |
12.0.6 | 12.0.7 | |
bare-events |
2.4.2 | 2.5.4 | |
base-x |
3.0.9 | 3.0.10 | |
big-integer |
1.6.51 | 1.6.52 | |
birecord |
- | 0.1.1 | |
bplist-creator |
0.1.0 | 0.0.7 | |
bplist-parser |
0.3.1 | 0.3.2 | |
bytes |
3.0.0 | 3.1.2 | |
call-bind-apply-helpers |
- | 1.0.1 | |
call-bind |
1.0.7 | 1.0.8 | |
call-bound |
- | 1.0.3 | |
caniuse-lite |
1.0.30001692 | 1.0.30001699 | |
chalk |
4.1.2 | 5.4.1 | |
chownr |
1.1.4 | 2.0.0 | |
ci-info |
2.0.0 | 3.9.0 | |
cjs-module-lexer |
1.2.3 | 1.4.3 | |
cli-cursor |
3.1.0 | 5.0.0 | |
cli-width |
3.0.0 | 4.1.0 | |
compact-encoding |
2.15.0 | 2.16.0 | |
compare-versions |
- | 6.1.1 | |
compression |
1.7.4 | 1.8.0 | |
crc-native |
1.0.11 | 1.1.6 | |
cross-fetch |
3.1.8 | 3.2.0 | |
csstype |
3.1.1 | 3.1.3 | |
data-view-buffer |
1.0.1 | - | |
data-view-byte-length |
1.0.1 | - | |
data-view-byte-offset |
1.0.0 | - | |
debounceify |
1.0.0 | 1.1.0 | |
decamelize |
1.2.0 | 6.0.0 | |
decimal.js |
10.4.3 | 10.5.0 | |
decompress-response |
6.0.0 | 3.3.0 | |
detect-libc |
2.0.2 | 1.0.3 | |
doctrine |
3.0.0 | - | |
domutils |
3.1.0 | 3.2.2 | |
dotenv-expand |
11.0.7 | 10.0.0 | |
dotenv |
16.4.5 | 16.4.7 | |
drizzle-orm |
0.30.8 | 0.30.10 | |
dunder-proto |
- | 1.0.1 | |
duplexify |
4.1.2 | 4.1.3 | |
electron-to-chromium |
1.5.80 | 1.5.97 | |
emoji-regex |
8.0.0 | 9.2.2 | |
enhanced-resolve |
5.18.0 | 5.18.1 | |
errorhandler |
1.5.1 | - | |
es-abstract |
1.23.3 | - | |
es-define-property |
1.0.0 | 1.0.1 | |
es-object-atoms |
1.0.0 | 1.1.1 | |
es-set-tostringtag |
2.0.3 | - | |
es-shim-unscopables |
1.0.0 | - | |
es-to-primitive |
1.2.1 | - | |
escape-string-regexp |
1.0.5 | 4.0.0 | |
eslint-config-prettier |
9.1.0 | - | |
eslint-plugin-eslint-comments |
3.2.0 | - | |
eslint-plugin-ft-flow |
2.0.3 | - | |
eslint-plugin-jest |
27.9.0 | 28.11.0 | |
eslint-plugin-react-debug |
- | 1.27.0 | |
eslint-plugin-react-dom |
- | 1.27.0 | |
eslint-plugin-react-hooks-extra |
- | 1.27.0 | |
eslint-plugin-react-hooks |
4.6.2 | - | |
eslint-plugin-react-naming-convention |
- | 1.27.0 | |
eslint-plugin-react-native |
4.0.0 | 5.0.0 | |
eslint-plugin-react-web-api |
- | 1.27.0 | |
eslint-plugin-react-x |
- | 1.27.0 | |
eslint-plugin-react |
7.31.10 | - | |
eslint-scope |
5.1.1 | 8.2.0 | |
eslint-visitor-keys |
2.1.0 | 3.4.3 | |
eslint |
8.47.0 | 9.21.0 | |
espree |
9.6.1 | 10.3.0 | |
esquery |
1.5.0 | 1.6.0 | |
estree-walker |
- | 2.0.2 | |
expect-webdriverio |
5.1.0 | 5.0.5 | |
expo-asset |
11.0.2 | 11.0.3 | |
exponential-backoff |
3.1.1 | 3.1.2 | |
fast-glob |
3.3.2 | 3.3.3 | |
fastify |
4.28.1 | 4.29.0 | |
fastq |
1.17.1 | 1.19.0 | |
figures |
3.2.0 | 6.1.0 | |
file-entry-cache |
6.0.1 | 8.0.0 | |
flat-cache |
3.0.4 | 4.0.1 | |
flat-tree |
1.9.0 | 1.12.1 | |
flatted |
3.2.7 | 3.3.2 | |
flow-parser |
0.206.0 | 0.260.0 | |
for-each |
0.3.3 | 0.3.5 | |
foreground-child |
3.1.1 | 3.3.0 | |
form-data |
3.0.2 | 4.0.1 | |
fs-minipass |
2.1.0 | 3.0.3 | |
fs-native-extensions |
1.2.3 | 1.3.3 | |
function.prototype.name |
1.1.6 | - | |
functions-have-names |
1.2.3 | - | |
get-intrinsic |
1.2.4 | 1.2.7 | |
get-port |
3.2.0 | 7.1.0 | |
get-proto |
- | 1.0.1 | |
get-symbol-description |
1.0.2 | - | |
glob-parent |
5.1.2 | 6.0.2 | |
globals |
11.12.0 | 16.0.0 | |
globalthis |
1.0.3 | 1.0.4 | |
gopd |
1.0.1 | 1.2.0 | |
has-bigints |
1.0.2 | - | |
has-proto |
1.0.3 | - | |
has-symbols |
1.0.3 | 1.1.0 | |
has |
1.0.3 | - | |
hermes-estree |
0.24.0 | 0.23.1 | |
hermes-parser |
0.24.0 | 0.23.1 | |
hosted-git-info |
7.0.2 | 4.1.0 | |
human-signals |
2.1.0 | 8.0.0 | |
hyperbee |
2.17.0 | 2.21.3 | |
hypercore-errors |
1.3.0 | 1.4.0 | |
hypercore-id-encoding |
1.3.0 | - | |
hypercore |
10.37.22 | 10.17.0 | |
hypertrace |
1.4.2 | - | |
iconv-lite |
0.6.3 | 0.4.24 | |
ignore |
5.3.1 | 5.3.2 | |
image-size |
1.1.1 | 1.2.0 | |
import-fresh |
3.3.0 | 3.3.1 | |
inquirer |
7.3.3 | 11.1.0 | |
internal-slot |
1.0.7 | - | |
is-arguments |
1.1.1 | 1.2.0 | |
is-array-buffer |
3.0.4 | - | |
is-bigint |
1.0.4 | - | |
is-boolean-object |
1.1.2 | - | |
is-core-module |
2.13.1 | 2.16.1 | |
is-data-view |
1.0.1 | - | |
is-date-object |
1.0.5 | - | |
is-fullwidth-code-point |
3.0.0 | 4.0.0 | |
is-generator-function |
1.0.10 | 1.1.0 | |
is-immutable-type |
- | 5.0.1 | |
is-negative-zero |
2.0.3 | - | |
is-number-object |
1.0.7 | - | |
is-regex |
1.1.4 | 1.2.1 | |
is-shared-array-buffer |
1.0.3 | - | |
is-stream |
3.0.0 | 4.0.1 | |
is-string |
1.0.7 | - | |
is-symbol |
1.0.4 | - | |
is-typed-array |
1.1.13 | 1.1.15 | |
is-weakref |
1.0.2 | - | |
is-wsl |
1.1.0 | 2.2.0 | |
isarray |
1.0.0 | 2.0.5 | |
istanbul-lib-coverage |
3.2.0 | 3.2.2 | |
js-yaml |
3.14.1 | 4.1.0 | |
jsesc |
3.0.2 | 3.1.0 | |
json-buffer |
3.0.0 | 3.0.1 | |
json-stable-stringify |
1.1.1 | 1.2.1 | |
jsx-ast-utils |
3.3.3 | - | |
keyv |
3.1.0 | 4.5.4 | |
ky |
1.7.2 | 1.7.4 | |
long |
5.2.3 | 5.3.0 | |
lru-cache |
6.0.0 | 5.1.1 | |
make-fetch-happen |
13.0.0 | 13.0.1 | |
math-intrinsics |
- | 1.1.0 | |
metro-config |
0.81.0 | 0.81.1 | |
metro-runtime |
0.81.0 | 0.81.1 | |
mime-db |
1.52.0 | 1.53.0 | |
mime |
2.6.0 | 4.0.6 | |
mimic-fn |
2.1.0 | 4.0.0 | |
mimic-response |
3.1.0 | 1.0.1 | |
minipass-fetch |
3.0.4 | 3.0.5 | |
mirror-drive |
1.3.0 | 1.4.0 | |
mute-stream |
0.0.8 | 1.0.0 | |
napi-build-utils |
1.0.2 | 2.0.0 | |
napi-macros |
2.2.2 | - | |
natural-compare-lite |
1.4.0 | - | |
nocache |
3.0.4 | - | |
node-abi |
3.51.0 | 3.74.0 | |
node-gyp-build |
4.6.1 | 4.8.4 | |
noise-handshake |
3.0.3 | 3.1.0 | |
nopt |
7.2.0 | 7.2.1 | |
npm-run-path |
5.3.0 | 6.0.0 | |
nwsapi |
2.2.13 | 2.2.16 | |
object-inspect |
1.13.1 | 1.13.4 | |
object-is |
1.1.5 | 1.1.6 | |
object.assign |
4.1.5 | 4.1.7 | |
object.entries |
1.1.5 | - | |
object.fromentries |
2.0.5 | - | |
object.hasown |
1.1.1 | - | |
object.values |
1.1.5 | - | |
on-finished |
2.4.1 | 2.3.0 | |
onetime |
5.1.2 | 7.0.0 | |
open |
6.4.0 | 7.4.2 | |
optionator |
0.9.3 | 0.9.4 | |
ora |
5.4.1 | 3.4.0 | |
p-defer |
4.0.0 | 4.0.1 | |
p-limit |
2.3.0 | 3.1.0 | |
p-timeout |
4.1.0 | 6.1.4 | |
parse-json |
4.0.0 | 5.2.0 | |
parse5 |
7.1.2 | 7.2.1 | |
path-key |
2.0.1 | 3.1.1 | |
picomatch |
2.3.1 | 4.0.2 | |
pino |
9.5.0 | 9.6.0 | |
plist |
3.0.6 | 3.1.0 | |
possible-typed-array-names |
1.0.0 | 1.1.0 | |
prebuild-install |
7.1.1 | 7.1.3 | |
pretty-format |
26.6.2 | 29.7.0 | |
pretty-ms |
9.1.0 | 9.2.0 | |
process-warning |
4.0.0 | 3.0.0 | |
promise |
8.3.0 | 7.3.1 | |
protomux |
3.5.1 | 3.10.1 | |
psl |
1.9.0 | 1.15.0 | |
pump |
3.0.0 | 3.0.2 | |
punycode |
2.1.1 | 2.3.1 | |
quickbit-native |
2.2.0 | 2.3.5 | |
rache |
- | 1.0.0 | |
random-access-file |
4.0.4 | 4.1.2 | |
random-access-storage |
3.0.1 | 3.0.2 | |
react-freeze |
1.0.3 | 1.0.4 | |
read-pkg-up |
7.0.1 | 10.1.0 | |
read-pkg |
5.2.0 | 8.1.0 | |
readable-stream |
4.5.2 | 3.6.2 | |
readdirp |
3.6.0 | 4.1.1 | |
ready-resource |
1.0.0 | 1.1.1 | |
regenerator-runtime |
0.13.11 | 0.14.1 | |
regexp.prototype.flags |
1.5.2 | - | |
resolve |
1.22.8 | 1.22.10 | |
restore-cursor |
3.1.0 | 5.1.0 | |
rtl-detect |
1.0.4 | 1.1.2 | |
run-async |
2.4.1 | 3.0.0 | |
rxjs |
6.6.7 | 7.8.1 | |
safe-array-concat |
1.1.2 | - | |
safe-buffer |
5.1.2 | 5.2.1 | |
safe-regex-test |
1.0.3 | 1.1.0 | |
sax |
1.3.0 | 1.4.1 | |
scheduler |
0.23.2 | 0.24.0-canary-efb381bbf-20230505 | |
send |
0.18.0 | 0.19.1 | |
serve-static |
1.15.0 | 1.16.2 | |
set-function-name |
2.0.2 | - | |
shell-quote |
1.7.4 | 1.8.2 | |
side-channel |
1.0.4 | - | |
signal-exit |
3.0.7 | 4.1.0 | |
simdle-native |
1.2.0 | 1.3.5 | |
sodium-native |
- | 4.3.1 | |
sodium-secretstream |
1.1.0 | 1.1.1 | |
source-map-support |
0.5.13 | 0.5.21 | |
spdx-license-ids |
3.0.20 | 3.0.21 | |
sprintf-js |
1.0.3 | 1.1.3 | |
statuses |
2.0.1 | 1.5.0 | |
stream-buffers |
2.2.0 | 3.0.3 | |
stream-shift |
1.0.1 | 1.0.3 | |
string-natural-compare |
3.0.1 | - | |
string-ts |
- | 2.2.1 | |
string-width |
4.2.3 | 5.1.2 | |
string.prototype.matchall |
4.0.7 | - | |
string.prototype.trim |
1.2.9 | - | |
string.prototype.trimend |
1.0.8 | - | |
string.prototype.trimstart |
1.0.8 | - | |
strip-ansi |
6.0.1 | 7.1.0 | |
strip-final-newline |
2.0.0 | 4.0.0 | |
sudo-prompt |
9.2.1 | 8.2.5 | |
svgo |
3.0.2 | 3.3.2 | |
tar-fs |
2.1.1 | 3.0.8 | |
tar-stream |
2.2.0 | 3.1.7 | |
terser |
5.37.0 | 5.38.2 | |
text-decoder |
1.1.1 | 1.2.3 | |
throttle-debounce |
5.0.0 | 5.0.2 | |
tmp |
0.0.33 | 0.2.3 | |
ts-api-utils |
1.3.0 | 2.0.1 | |
ts-declaration-location |
- | 1.0.5 | |
ts-pattern |
- | 5.6.2 | |
tsutils |
3.21.0 | - | |
typed-array-buffer |
1.0.2 | - | |
typed-array-byte-length |
1.0.1 | - | |
typed-array-byte-offset |
1.0.2 | - | |
typed-array-length |
1.0.6 | - | |
typescript-eslint |
- | 8.25.0 | |
ua-parser-js |
1.0.35 | 0.7.40 | |
unbox-primitive |
1.0.2 | - | |
undici |
6.21.0 | 6.21.1 | |
update-browserslist-db |
1.1.1 | 1.1.2 | |
uuid |
3.4.0 | 10.0.0 | |
varint |
5.0.2 | 6.0.0 | |
webidl-conversions |
5.0.0 | 7.0.0 | |
which-boxed-primitive |
1.0.2 | - | |
which-runtime |
- | 1.2.1 | |
which-typed-array |
1.1.15 | 1.1.18 | |
word-wrap |
- | 1.2.5 | |
ws |
7.5.10 | 8.18.0 | |
xache |
1.2.0 | 1.2.1 | |
xcode |
2.1.0 | 3.0.1 | |
xmlbuilder |
15.1.1 | 14.0.0 | |
yallist |
4.0.0 | 3.1.1 | |
yargs-parser |
21.1.1 | 20.2.9 | |
z32 |
1.0.1 | 1.1.0 |
achou11
changed the title
achou11
force-pushed
the
ac/upgrade-eslint
branch
from
4994618 to
51e7de1
Compare
achou11
force-pushed
the
ac/upgrade-eslint
branch
from
1bd4cfb to
e7e4cc7
Compare
achou11
force-pushed
the
ac/upgrade-eslint
branch
from
79802e4 to
7bc8761
Compare
There was a problem hiding this comment.
Im glad that we are using the new eslint architecture. There are a lot of new rules introduced by the premade/recommended configs. Running eslint introduced 99 problems (but a bitch aint one 😆 ) - 71 error and 28 warnings.
I think we should using these recommended configs but Im wondering if it should be the job of this PR to solve the new errors associated with it?
There was a problem hiding this comment.
I think we should using these recommended configs but Im wondering if it should be the job of this PR to solve the new errors associated with it?
I'm in favor of addressing the issues as follow-ups, mostly because we haven't made an effort to address the issues prior to this PR anyways. I've added the automatic fixes in this PR but if the issues don't fall under that category, I think it's safer to have dedicated PRs to address them.
I'm mostly interested in keeping this PR's scope to updating the tooling and configuration. I think decisions around things like the following are better served as follow-ups:
- deciding which rules to enable/disable
- incorporating CI checks
- addressing the actual issues
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "mapeo-mobile-node-next", | |||
| "version": "1.0.0", | |||
| "lockfileVersion": 2, | |||
| "lockfileVersion": 3, | |||
There was a problem hiding this comment.
just noting that the massive diff in this file (aside from removing eslint) is due to the lockfile version changing. I think this is desirable in our case, as v3 is associated for npm v9 and later, which aligns with the versions of node that matter to us (18 + 20)
https://docs.npmjs.com/cli/v11/configuring-npm/package-lock-json#lockfileversion
not really sure why the lockfile version changed in this PR versus other PRs where we updated backend deps though 🤔
| @@ -2,8 +2,8 @@ import {useEffect, useState} from 'react'; | |||
| import {Duration} from 'luxon'; | |||
|
|
|||
| export const useFormattedTimeSince = (start: Date | null, interval: number) => { | |||
| const [currentTime, setCurrentTime] = useState(new Date()); | |||
| let startDate = start ? new Date(start) : new Date(); | |||
| const [currentTime, setCurrentTime] = useState(() => new Date()); | |||
There was a problem hiding this comment.
Which rule complained about this? These are the kind of rules in eslint that bug me a bit. Yes it saves an unnecessary new Date() on each render, but that is a pico-optimization.
There was a problem hiding this comment.
https://eslint-react.xyz/docs/rules/hooks-extra-prefer-use-state-lazy-initialization
yes it's a minor optimization but it's the unfortunate reality of how react works. i'd rather enforce consistency on this rather than relying on everyone to have a deep enough knowledge about this potentially consequential limitation in React
achou11
force-pushed
the
ac/upgrade-eslint
branch
from
041f24d to
0096c49
Compare
achou11
force-pushed
the
ac/upgrade-eslint
branch
from
0096c49 to
6f4b608
Compare
|
did an initial pass on adjusting rules that are unanimously less helpful and addressing the resulting errors and warnings in 6f4b608. Kind of wish I did a stacked PR so that changes in the app code could be easier to see. happy to move things around if desirable. couple of observations:
while the bugs found so far are relatively minor, nothing stops us from introducing major bugs with these rules being disabled down the line. i'd rather put in the early foundations to mitigate those cases, even if they present some inconveniences in the development experience |
|
To be discussed tomorrow. I agree with Andrew about the The only one I dont agree with is Otherwise the rest of the rules seem good for me. |
Yeah agreed, i don't find this rule super helpful although I kind of understand the reasoning. Will disable it 👍 |
@react-native/eslint-config) due to compat issues with the typescript eslint plugin it uses internally.applies very trivial fixes that could be automated by the eslint check (i.e. with itsEDIT: applies fixes to relevant and easy-to-address issues--fix) flag.Remaining items (can be done as follow-ups):
decide whether or not not having rules specific to React Native for now is a blocker. Can spend some time attempting to get it working but would be okay with doing as a follow-up.EDIT: addressed via ad35fdcadjust the react configuration to omit non-applicable rules (e.g. no need for
dom)