feat: indicate tracks from other users #975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimigree
reviewed
Feb 20, 2025
| const {data: deviceInfo} = useDeviceInfo(); | ||
|
|
||
| const isMine = | ||
| createdByDeviceId && createdByDeviceId === deviceInfo?.deviceId; |
There was a problem hiding this comment.
would it make any sense to put this in a hook or function and returns a simple boolean?
useIsMine(originalVersionId) or something?
Then the render function in the list item is more about layout and style?
cimigree
reviewed
Feb 20, 2025
| status: originalVersionIdToDeviceIdQueryStatus, | ||
| } = useOriginalVersionIdToDeviceId(observation.originalVersionId); | ||
| const isMine = createdByDeviceId === deviceInfo?.deviceId; | ||
| const queriesSucceeded = |
There was a problem hiding this comment.
Is it worth still checking if deviceInfo or createdByDeviceId is still loading? If so, would the isMine be incorrect (in the new file) and thus apply the incorrect styling? (would default to not isMine when I am not sure that is the more likely scenario)
cimigree
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #936