Skip to content

fix: disable expo updates (fix Android 7 crash) #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

gmaclennan
Copy link
Member

Expo updates is crashing Android 7 devices in the latest version (#983)

Expo updates allow over-the-air updates of bundled JS code. We currently do not use this feature, but it is enabled by default (https://docs.expo.dev/versions/latest/config/app/#enabled). Disabling the option should have no consequences for the app, it avoid unnecessary network traffic, and reduces the bundle size.

Expo updates is crashing Android 7 devices in the latest version (#983)

Expo updates allow over-the-air updates of bundled JS code. We currently do not use this feature, but it is enabled by default (https://docs.expo.dev/versions/latest/config/app/#enabled). Disabling the option should have no consequences for the app, it avoid unnecessary network traffic, and reduces the bundle size.
@gmaclennan gmaclennan self-assigned this Feb 19, 2025
@gmaclennan gmaclennan requested a review from achou11 February 19, 2025 20:02
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove expo-updates as a dep then?

@awana-lockfile-bot
Copy link

package-lock.json changes

Click to toggle table visibility
Name Status Previous Current
expo-eas-client REMOVED 0.13.2 -
expo-structured-headers REMOVED 4.0.0 -
expo-updates REMOVED 0.26.13 -

@gmaclennan
Copy link
Member Author

Can we also remove expo-updates as a dep then?

I think so, let's see if tests pass with it removed.

@gmaclennan gmaclennan merged commit a28e01c into develop Feb 19, 2025
7 checks passed
@gmaclennan gmaclennan deleted the fix/turn-off-updates branch February 19, 2025 20:46
@achou11 achou11 mentioned this pull request Feb 19, 2025
ErikSin pushed a commit that referenced this pull request Feb 24, 2025
* fix: disable expo updates (OTA updates of JS code)

Expo updates is crashing Android 7 devices in the latest version (#983)

Expo updates allow over-the-air updates of bundled JS code. We currently do not use this feature, but it is enabled by default (https://docs.expo.dev/versions/latest/config/app/#enabled). Disabling the option should have no consequences for the app, it avoid unnecessary network traffic, and reduces the bundle size.

* chore: remove expo-updates dep

* fix: Remove update channel option from eas.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants