Story/cite 163 - - We need a bulk upload for files. #23
+686
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
9 tasks
jdamerow
requested changes
Mar 19, 2025
citesphere-importer/pom.xml
Outdated
| <groupId>org.springframework.security.oauth</groupId> | ||
| <artifactId>spring-security-oauth2</artifactId> | ||
| <version>${spring-security-oauth2-version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
How is this file different than the ImportProcessor?
| fields.put(key, value); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is very brittle (I don't think bibtex is that strict with placing of curly brackets. etc?). I would use a parsing library (jbibtext seems to be the most popular one and while there is not a ton of activity, at least there is some).
citesphere-importer/pom.xml
Outdated
| <groupId>org.springframework</groupId> | ||
| <artifactId>spring-test</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
We need a bulk upload for files.
... Put ticket description here and add link to ticket ...
The user would create a BibText export that includes files via Zotero (Zotero -> export collection -> BibTex format with "include files" checked). They would then zip the folder that Zotero exports and upload it to Citesphere. Citesphere would send it to the Citesphere Importer component (via Kafka like the other imports) and the importer would then create references in the zotero group the user specifies for the import (like for the web of science import that has no files) and send the files to Giles for processing (similar to how Giles sends individual files to Giles for processing).
https://diging.atlassian.net/browse/CITE-163
Are there any other pull requests that this one depends on?
diging/spring-social-zotero#24
diging/citesphere-messages#13
diging/citesphere-model#57
Anything else the reviewer needs to know?
... describe here ...