Skip to content

Story/cite 189 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Story/cite 189 #236

wants to merge 10 commits into from

Conversation

agoyal61
Copy link
Contributor

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

https://diging.atlassian.net/browse/CITE-189

... Put ticket description here and add link to ticket ...

On the citation list page, it should be possible to filter by type.

Are there any other pull requests that this one depends on?

diging/citesphere-model#45

Anything else the reviewer needs to know?

... describe here ...

@diging-jenkins
Copy link

Can one of the admins verify this patch?

jdamerow
jdamerow requested changes Mar 23, 2023
View reviewed changes
citesphere/src/main/webapp/WEB-INF/views/auth/group/items.html Outdated
<span th:each="citationType:${T(edu.asu.diging.citesphere.model.bib.ItemType).values()}">
<option th:selected="${#strings.equals(itemType, citationType)}" th:value="${citationType}" th:text="${citationType}">[[${citationType}]]</option>
</span>
</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we said the dropdown should be next to the other filter for concepts

citesphere/src/main/webapp/WEB-INF/views/auth/group/items.html Outdated
console.log("itemType " + itemType);
console.log(window.location.href);
window.location.href = "?itemType=" + itemType;
console.log(window.location.href);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have any sysout statements in my code or commented out code that isn’t needed anymore

@jdamerow jdamerow closed this Mar 23, 2023
@agoyal61 agoyal61 reopened this Mar 31, 2023
@jdamerow
Copy link
Member

Make it so, Jenkins.

@diging-jenkins
Copy link

Build failed. Maybe you broke the test cases?

@jdamerow
Copy link
Member 

[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /var/lib/jenkins/workspace/citesphere_deploy_to_review_on_pr/citesphere/src/main/java/edu/asu/diging/citesphere/core/service/impl/CitationManager.java:[411,54] method findCitationsInCollection in interface edu.asu.diging.citesphere.data.bib.ICitationDao cannot be applied to given types;
  required: java.lang.String,java.lang.String,long,int,java.util.List<java.lang.String>
  found: java.lang.String,java.lang.String,int,java.lang.Integer,java.util.List<java.lang.String>,java.lang.String
  reason: actual and formal argument lists differ in length
[ERROR] /var/lib/jenkins/workspace/citesphere_deploy_to_review_on_pr/citesphere/src/main/java/edu/asu/diging/citesphere/core/service/impl/CitationManager.java:[419,54] method findCitations in interface edu.asu.diging.citesphere.data.bib.ICitationDao cannot be applied to given types;
  required: java.lang.String,long,int,boolean,java.util.List<java.lang.String>
  found: java.lang.String,int,java.lang.Integer,boolean,java.util.List<java.lang.String>,java.lang.String
  reason: actual and formal argument lists differ in length
[INFO] 2 errors

@jdamerow jdamerow closed this May 18, 2023
@rajvi-patel-22 rajvi-patel-22 reopened this Oct 8, 2025
@diging-jenkins
Copy link

Build failed. Maybe you broke the test cases?

@rajvi-patel-22 rajvi-patel-22 marked this pull request as draft October 10, 2025 16:06
@diging-jenkins
Copy link

Build failed. Maybe you broke the test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdamerow jdamerow jdamerow requested changes

Assignees

@jdamerow jdamerow

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agoyal61 @diging-jenkins @jdamerow @rajvi-patel-22