Story/CITE-173 : Reprocessing Documents #248
Open
+347
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
pr description needs to be filled out |
jdamerow
requested changes
Oct 20, 2023
| @Override | ||
| public ResponseEntity<String> reprocessDocument(IUser user, String documentId) { | ||
| ResponseEntity<String> response = sendRequest(user, reprocessingEndpoint.replace("{0}", documentId), String.class, HttpMethod.POST); | ||
| return response; |
| throws GroupDoesNotExistException, CannotFindCitationException, ZoteroHttpStatusException, | ||
| ZoteroConnectionException, CitationIsOutdatedException, ZoteroItemCreationFailedException { | ||
| ICitation citation = getCitation(user, zoteroGroupId, itemId); | ||
| for (Iterator<IGilesUpload> gilesUpload = citation.getGilesUploads().iterator(); gilesUpload.hasNext();) { |
There was a problem hiding this comment.
should actually be a stream that filters for the upload with the document id
| checkedUploads.add(reprocessedUpload); | ||
| updateCitationWithUpdatedGilesUpload(checkedUploads, user, citation, documentId); | ||
| gilesUploadChecker.add(citation); | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
move catch block up to where it is thrown.
| try { | ||
| jsonNode = objectMapper.readTree(responseBody); | ||
| String checkUrl = jsonNode.get("checkUrl").asText(); | ||
| String[] urlSegments = checkUrl.split("/"); |
There was a problem hiding this comment.
should be taken directly from id property of response
| } | ||
| } | ||
|
|
||
| private void updateCitationWithUpdatedGilesUpload(Set<IGilesUpload> checkedUploads, IUser user, ICitation citation, String documentId) { |
jdamerow
requested changes
Apr 24, 2024
|
|
||
| private void initiateReprocessing(IUser user, String documentId, ICitation citation) { | ||
| ResponseEntity<String> reprocessingResponse = gilesConnector.reprocessDocument(user, documentId); | ||
| if (reprocessingResponse.getStatusCode().equals(HttpStatus.OK)) { |
There was a problem hiding this comment.
if it's not ok, the user needs to know this.
| JsonNode jsonNode = objectMapper.readTree(responseBody); | ||
| progressId = jsonNode.get("id").asText(); | ||
| } catch (IOException e) { | ||
| logger.error("Could not deserialize response.", e); |
There was a problem hiding this comment.
this should probably not simply be ignored but the user needs to know. the rest doesn't really make sense if this fails, does it?
| logger.error("Could not get citation.", e); | ||
| } catch (ZoteroHttpStatusException e) { | ||
| logger.error("Could not get citation.", e); | ||
| } |
There was a problem hiding this comment.
again, it seems like a bad idea to just ignore this
| throws GroupDoesNotExistException, CannotFindCitationException, ZoteroHttpStatusException, | ||
| ZoteroConnectionException, CitationIsOutdatedException, ZoteroItemCreationFailedException { | ||
| citationManager.reprocessFile((IUser) authentication.getPrincipal(), zoteroGroupId, itemId, documentId); | ||
| return new ResponseEntity<>(HttpStatus.OK); |
There was a problem hiding this comment.
if the reprocessing throws an error, the return should not be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
https://diging.atlassian.net/browse/CITE-173
Added the reprocessing button for reprocessing the files
Are there any other pull requests that this one depends on?
Anything else the reviewer needs to know?
... describe here ...