Bug/cite 229 - Checking access of an upload in progress should be possible with the upload id. #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jdamerow
requested changes
Apr 29, 2025
| this.documentIds = documentIds; | ||
| } | ||
| } |
There was a problem hiding this comment.
is there a reason for this change?
.../src/main/java/edu/asu/diging/citesphere/core/service/giles/impl/GilesUploadCheckerImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/edu/asu/diging/citesphere/core/service/giles/impl/GilesUploadCheckerImpl.java
Outdated
Show resolved
Hide resolved
jdamerow
requested changes
May 6, 2025
| continue; | ||
| ObjectMapper mapper = new ObjectMapper(); | ||
| String jsonBody = response.getBody(); | ||
| GilesCheckUploadResponse processed = new GilesCheckUploadResponse(); |
There was a problem hiding this comment.
this does not need to be initialized here does it? it either is set in line 147 or processed will never be used?
| @@ -153,6 +168,7 @@ public void checkUploads() { | |||
| logger.error("Could not deserialize response.", e); | |||
| upload.setDocumentStatus(GilesStatus.FAILED); | |||
| checkedUploads.add(upload); | |||
| continue; | |||
There was a problem hiding this comment.
if this is added here, then processed does not need to be initialized in line 164, does it?
| this.documentIds = documentIds; | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
Checking access of an upload in progress should be possible with the upload id.
... Put ticket description here and add link to ticket ...
Right now, you need the documentId of a finished uploaded document or a progress id to check if a user has access to a giles upload. Citesphere, when checking the progress of an upload, needs to store the upload id (after the initial submission, there is just a progress id). And then in the CheckAccessController, it needs to also be possible to send the Upload Id.
(this is for the API endpoint)
https://diging.atlassian.net/browse/CITE-229
Are there any other pull requests that this one depends on?
diging/citesphere-model#56
Anything else the reviewer needs to know?
... describe here ...