Skip to content

Conversation

jophals
Copy link
Contributor

@jophals jophals commented Jun 27, 2025

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

Tests are not running with Java 17

VSPC-279

Anything else the reviewer needs to know?

@jophals jophals requested a review from jdamerow June 27, 2025 00:11
@jophals jophals self-assigned this Jun 27, 2025
@diging-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@diging-jenkins
Copy link

Can one of the admins verify this patch?

@jophals
Copy link
Contributor Author

jophals commented Jun 27, 2025

Make it so, Jenkins

@jophals
Copy link
Contributor Author

jophals commented Jun 27, 2025

So I got the tests to work with Java 17 by making a few changes to some dependencies and plugins. There appears to be some issues with the tests as they are currently written but the tests are running and the errors are not related to
Java 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants