Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
123 commits
Select commit Hold shift + click to select a range
36843b0
[VSPC-147] Intial changes and new files created for Bibliography bloc…
pradeep-017 May 5, 2021
5df90f2
Merge branch 'develop' into story/VSPC-147
pradeep-017 May 6, 2021
afbde02
[VSOC-147] Edit Bibliography controller created and using it in slide…
pradeep-017 May 7, 2021
4e7397f
[VSPC-147] code cleaning for slide.html
pradeep-017 May 10, 2021
73bda55
Merge branch 'develop' into story/VSPC-147
pradeep-017 May 10, 2021
30f114b
[VSPC-147] Delete functionality for bibliography and button alignment…
pradeep-017 May 11, 2021
4eb9091
[VSPC-147] Code indentation changes for slide.html
pradeep-017 May 12, 2021
9ccba7f
[VSPC-147] Code indentation fix for slide.html
pradeep-017 May 12, 2021
c6a3aac
[VSPC-147] Adding more fields for bibliography - Work in progress
pradeep-017 May 12, 2021
806c6f3
Merge branch 'story/VSPC-147' of https://github.com/diging/virtual-sp…
pradeep-017 May 12, 2021
ecc0a56
[VSPC-147] Added new fields and worked on CRUD opeerations to work on…
pradeep-017 May 17, 2021
d79ca74
[VSPC-147] Tests for bibliography feature on slides-Work in progress
pradeep-017 May 18, 2021
e78221a
[VSPC-147] Test cases for Bibliography
pradeep-017 May 19, 2021
0efa1c4
Merge branch 'develop' into story/VSPC-147
pradeep-017 May 19, 2021
e35d814
[VSPC-147] csrf token passing via headers enabled for ajax calls and …
pradeep-017 May 27, 2021
ef356a5
[VSPC-147] Image icon changed for bibliography and bibliographies now…
pradeep-017 Jun 8, 2021
1472da8
[VSPC-147] Corrected id tags for slide contents on public page, Bibli…
pradeep-017 Jun 9, 2021
6cfd2dc
[VSPC-147] Changes for bibliography citations and making Zotero detec…
pradeep-017 Jun 11, 2021
1f705ce
[VSPC-147] Changes for bibliography metadata view on public page for …
pradeep-017 Jun 11, 2021
cd5de7c
[VSPC-147] Detection of Bibliographies by Zotero - General functional…
pradeep-017 Jun 14, 2021
23c7a6e
Merged develop into story/VSPC-147
pradeep-017 Jun 15, 2021
050434c
[VSPC-147] Code changes for returning json afetr creation of Bibliogr…
pradeep-017 Jun 17, 2021
6a97e07
[VSPC-147] Json response checks and handling for bibliography creation
pradeep-017 Jun 18, 2021
b911508
[VSPC-147] Updated biblio exception class for code factor error check
pradeep-017 Jun 18, 2021
fa4b232
[VSPC-147] Exposing Biblipgraphy metadata to be picked up by zotero
pradeep-017 Jun 21, 2021
4ab456d
[VSPC-147] Exposing bibliography metadata to be picked by zotero - St…
pradeep-017 Jun 22, 2021
97de8e4
[VSPC-147] Intriducing Reference class under Bibliography and related…
pradeep-017 Jun 22, 2021
4701276
[VSPC-147] Added Reference factory, manager, controller classes. Chan…
pradeep-017 Jun 23, 2021
b6a6931
[VSPC-147] changes for CRUD on bibliography block and references
pradeep-017 Jun 24, 2021
e011fd2
[VSPC-147] AddReference controller and bringing references under bibl…
pradeep-017 Jun 25, 2021
9cdcada
[VSPC-147] Add and Edit Reference completed, Created Exception class
pradeep-017 Jun 28, 2021
f9a8d02
[VSPC-147] Completed Delete operation on References and corrected few…
pradeep-017 Jun 29, 2021
12e017f
[VSPC-147] Delete Bibliographies handled by taking care of deleteing …
pradeep-017 Jul 1, 2021
c127e4f
[VSPC-147] Completed changes for showing bibliographies and reference…
pradeep-017 Jul 2, 2021
f1cba65
[VSPC-147] CHanges for writing tests (in progress) and working review…
pradeep-017 Jul 6, 2021
32fd3ec
[VSPC-147] Changes for making BiblioBlock and References indepedent a…
pradeep-017 Jul 7, 2021
8572b9e
[VSPC-147] Completed changes for Bibliography and reference blocks on…
pradeep-017 Jul 8, 2021
e052749
VSPC-147 Spacing Loading error fixed
ajay3568yadav Apr 5, 2024
2459455
VSPC-147 fixed biblio block display
ajay3568yadav Apr 12, 2024
fa9c77b
VSPC-147 bibliography block
ajay3568yadav Apr 17, 2024
f742c0e
VSPC-147 biblio block fixed
ajay3568yadav Apr 20, 2024
612e7e3
VSPC-147 Fixed, Biblio and reference blocks
ajay3568yadav Apr 26, 2024
f8c00cb
VSPC-147 Merge resolve
ajay3568yadav May 3, 2024
24011d2
VSPC-147 fixed biblio and text block alignment issue
ajay3568yadav May 3, 2024
9d699a1
VSPC-147 fixed formatting for review
ajay3568yadav May 3, 2024
231eefc
VSPC-147 review comments
ajay3568yadav May 3, 2024
0695d5f
VSPC-147 codefactor issue fixed and review comments
ajay3568yadav May 9, 2024
2ad65f2
VSPC-147 review comment
ajay3568yadav May 9, 2024
95eb77b
VSPC-147 codefactor warning fix
ajay3568yadav May 9, 2024
69cb8dc
VSPC-147 review comments
ajay3568yadav May 23, 2024
b7905f7
VSPC-147 review comments
ajay3568yadav May 31, 2024
052900c
[VSPC-147] review comments about 404 not found
ajay3568yadav Jun 7, 2024
e955bc5
[VSPC-147] review comments
ajay3568yadav Jun 14, 2024
ee06fdd
[VSPC-147] review comments fix
ajay3568yadav Jun 14, 2024
0624225
VSPC-147 added 404 not found
ajay3568yadav Jun 24, 2024
bef1adc
VSPC-147 fixed bibiliblock miss references
ajay3568yadav Jul 16, 2024
34343d9
VSPC-147 404
ajay3568yadav Jul 17, 2024
5e4a5da
VSPC-147 bibiliblock 404
ajay3568yadav Jul 17, 2024
e91d0db
VSPC-147 review comments
ajay3568yadav Jul 25, 2024
48808b9
VSPC-147 fixed broken code
ajay3568yadav Aug 13, 2024
dec778a
VSPC-147 review comments
ajay3568yadav Aug 14, 2024
8e200fe
VSPC-147 review comments 404
ajay3568yadav Aug 14, 2024
fc52e03
VSPC-147 re-formatting
ajay3568yadav Aug 16, 2024
f086a2c
Merge branch 'develop' of https://github.com/diging/virtual-spaces-2.…
ajay3568yadav Aug 16, 2024
b42a8e7
VSPC-147 indentation fix
ajay3568yadav Aug 22, 2024
a5f9720
VSPC-147 rev iew comments
ajay3568yadav Aug 23, 2024
fa76448
VSPC-147 indentation 2
ajay3568yadav Aug 28, 2024
31188e9
VSPC-147 indentation fix
ajay3568yadav Aug 30, 2024
eb55561
VSPC-147 indentation
ajay3568yadav Sep 5, 2024
96de529
VSPC-147 indent fix
ajay3568yadav Sep 6, 2024
42b1273
VSPC-171 removed extra document ready function
ajay3568yadav Sep 11, 2024
4671b33
VSPC-171 buttons indentation fixed
ajay3568yadav Sep 11, 2024
dc5ca80
VSPC-147 merge conflicts fix
ajay3568yadav Sep 11, 2024
2b47341
Merge branch 'develop' into story/VSPC-147
ajay3568yadav Sep 11, 2024
0b43db6
VSPC-147 review comment on logger
ajay3568yadav Sep 12, 2024
87ab2fe
Merge branch 'story/VSPC-147' of https://github.com/diging/virtual-sp…
ajay3568yadav Sep 12, 2024
57c9cfd
VSPC-147 bibliography review comments
ajay3568yadav Sep 12, 2024
877353e
VSPC-147 review comments on biblioblock method name and logger
ajay3568yadav Sep 13, 2024
c17de2c
VSCP-147 test build fail test1
ajay3568yadav Sep 18, 2024
a402f07
VSCP-147 revert
ajay3568yadav Sep 18, 2024
6315712
VSPC-147 test 2
ajay3568yadav Sep 18, 2024
5c44b28
VSPC-147 contentblock manager title descrioption fixed
ajay3568yadav Sep 18, 2024
2e095e6
VSPC-147 test
ajay3568yadav Sep 18, 2024
655bbab
VSPC-147 added ArgumentCaptor
ajay3568yadav Sep 18, 2024
96c9d04
VSPC-147 test 3
ajay3568yadav Sep 18, 2024
0ac18e2
VSPC-147 reference manager test
ajay3568yadav Sep 18, 2024
762acd7
VSCP-147 test 4
ajay3568yadav Sep 19, 2024
7351ed5
VSPC-147 test 5
ajay3568yadav Sep 19, 2024
f51d67b
VSPC-147 logger comment
ajay3568yadav Sep 25, 2024
f7208eb
[VSPC-147] trying to fix the review side code not updated
ajay3568yadav Oct 4, 2024
4641c9c
[VSPC-147] recommitting previous to fix
ajay3568yadav Oct 4, 2024
9e0947d
Review comments pom.xml DateOffset exception
ajay3568yadav Nov 27, 2024
b35c925
VSPC-147 merged with develop and resolved conflicts
Dec 18, 2024
fbe0a92
VSPC-147 ref block debug
Dec 19, 2024
2f3787f
VSPC-147 debug attempt
Dec 20, 2024
6f4fc4a
VSPC-147 reference block edit fix attempt
Jan 2, 2025
ef83e24
VSPC-147 reference showing up again
Jan 3, 2025
55a032f
VSPC-147 removed console log statmenets
Jan 3, 2025
252596c
VSPC-147 finished ref block
Jan 6, 2025
c9cdd75
VSPC-147 cleaned controller checkstatements
Jan 6, 2025
b806615
VSPC-147 review comments
Jan 15, 2025
c6c167c
VSPC-147 review comments on types
Jan 15, 2025
98d66d7
VSPC-147 bibliogrphy review comments
Jan 17, 2025
fd12d7a
VSPC-147 review comments
Jan 31, 2025
9a72bf1
VSPC-150 formatting
Feb 7, 2025
81003bc
VSPC_147 review comments on html rendering
Feb 7, 2025
8021682
VSPC-150 sortable references
Feb 12, 2025
ff999bd
VSPC-150 fixed refereces sorting and added reference visibility
Feb 14, 2025
e84f8ec
VSCP-150 added private view functionality
Feb 19, 2025
c07b3fa
VSPC-147 review comments
Feb 21, 2025
f783d66
VSPC-147 review comments and content order fix
Feb 26, 2025
0465dcd
VSPC-147 content order issue addressing
Feb 28, 2025
e927036
VSPC-147 fixed contentOrder
ajay3568yadav Mar 5, 2025
ccc2a21
VSPC-147 review comments
ajay3568yadav Mar 7, 2025
63015c8
VSPC-150 merge with 147
ajay3568yadav Mar 7, 2025
aa2d567
VSPC-150 visibiity and reference issue
ajay3568yadav Mar 11, 2025
6913952
VSPC-150 slides reverted
ajay3568yadav Mar 12, 2025
8aff7e5
VSPC-147 review comments on parsing using Spring
ajay3568yadav Mar 12, 2025
3252d47
VSPC-147 review comments addressed
ajay3568yadav Mar 13, 2025
8bd3656
VSPC-150 merge conflicts with VSPC-147
ajay3568yadav Mar 14, 2025
71d2682
VSPC-150 refereblock double click fix attempt
ajay3568yadav Mar 21, 2025
5e32730
VSPC-150 revert
ajay3568yadav Mar 26, 2025
83641bb
VSPC-150 merge conflicts
ajay3568yadav Jun 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,10 @@ public interface IReference extends IVSpaceElement {
void setId(String id);

String getId();

void setVisibility(boolean visible);

boolean getVisibility();


}
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ public class Reference extends VSpaceElement implements IReference {
private String type;

private String note;

private boolean visibility;

@Override
public String getTitle() {
Expand Down Expand Up @@ -182,4 +184,13 @@ public void setBiblios(List<BiblioBlock> biblios) {
this.biblios = biblios;
}

@Override
public void setVisibility(boolean visibility) {
this.visibility = visibility;
}

@Override
public boolean getVisibility() {
return visibility;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public class ReferenceData {
private String editors;
private String type;
private String note;
private String visibility;


public String getTitle() {
Expand Down Expand Up @@ -81,5 +82,11 @@ public String getNote() {
public void setNote(String note) {
this.note = note;
}
public String getVisibility() {
return note;
}
public void setVisibility(String visibility) {
this.visibility = visibility;
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public interface IReferenceManager {

IReference getReference(String referenceId);

IReference createReference(String biblioId, String title, String author,String year,String journal, String url, String volume,String issue, String pages,String editor, String type, String note);
IReference createReference(String biblioId, String title, String author,String year,String journal, String url, String volume,String issue, String pages,String editor, String type, String note, String visibility);

void updateReference(IReference reference);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
private IContentBlockManager contentBlockManager;

@Override
public IReference createReference(String biblioId, String title, String author,String year,String journal, String url, String volume,String issue, String pages,String editor, String type, String note) {
public IReference createReference(String biblioId, String title, String author,String year,String journal, String url, String volume,String issue, String pages,String editor, String type, String note, String visibility) {

IReference reference = new Reference();
reference.setAuthor(author);
reference.setTitle(title);
Expand All @@ -42,6 +43,13 @@
reference.setEditors(editor);
reference.setType(type);
reference.setNote(note);
if(visibility == "Private") {
reference.setVisibility(false);

Check warning on line 47 in vspace/src/main/java/edu/asu/diging/vspace/core/services/impl/ReferenceManager.java

View check run for this annotation

codefactor.io / CodeFactor

vspace/src/main/java/edu/asu/diging/vspace/core/services/impl/ReferenceManager.java#L47

'if' child has incorrect indentation level 16, expected level should be 12. (com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck)
}
else {
reference.setVisibility(true);

Check warning on line 50 in vspace/src/main/java/edu/asu/diging/vspace/core/services/impl/ReferenceManager.java

View check run for this annotation

codefactor.io / CodeFactor

vspace/src/main/java/edu/asu/diging/vspace/core/services/impl/ReferenceManager.java#L50

'else' child has incorrect indentation level 16, expected level should be 12. (com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck)
}

BiblioBlock biblio = contentBlockManager.getBiblioBlock(biblioId);
reference.getBiblios().add(biblio);
return referenceRepo.save((Reference) reference);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ public class AddReferenceController {

@RequestMapping(value = "/staff/module/{id}/slide/{slideId}/bibliography/{biblioId}/reference/add",
method = RequestMethod.POST)
public ResponseEntity<IReference> addReference(@PathVariable("id") String moduleId,
public ResponseEntity<Reference> addReference(@PathVariable("id") String moduleId,

@PathVariable("slideId") String slideId,
@PathVariable("biblioId") String biblioId,
@RequestBody ReferenceData referenceData,
Expand All @@ -40,9 +41,10 @@ public ResponseEntity<IReference> addReference(@PathVariable("id") String module
referenceData.getPages(),
referenceData.getEditors(),
referenceData.getType(),
referenceData.getNote()
referenceData.getNote(),
referenceData.getVisibility()
);

return ResponseEntity.ok(ref);
return ResponseEntity.ok((Reference) ref);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ public ResponseEntity<String> editReference(@PathVariable("id") String slideId,
reference.setEditors(editor);
reference.setType(type);
reference.setNote(note);

referenceManager.updateReference(reference);
return new ResponseEntity<String>(HttpStatus.OK);
}
Expand Down
24 changes: 24 additions & 0 deletions vspace/src/main/webapp/WEB-INF/views/exhibition/module.html
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
.biblioDiv ul {
list-style: none;
padding: 0;
margin: 16px 0 0 0;

Check warning on line 80 in vspace/src/main/webapp/WEB-INF/views/exhibition/module.html

View check run for this annotation

codefactor.io / CodeFactor

vspace/src/main/webapp/WEB-INF/views/exhibition/module.html#L80

Expected "16px 0 0 0" to be "16px 0 0". (shorthand-property-no-redundant-values)
}

.referenceDiv {
Expand Down Expand Up @@ -133,6 +133,30 @@
function closeModal(){
$("#moduleOverviewModal").hide();
}

document.addEventListener('DOMContentLoaded', function() {
const sortSelect = document.getElementById('referenceSort');
const refList = document.getElementById('referenceList');

sortSelect.addEventListener('change', function() {
const sortBy = this.value;
let items = Array.from(refList.getElementsByTagName('li'));

items.sort((a, b) => {
const aValue = a.querySelector('.referenceDiv').getAttribute('data-' + sortBy);
const bValue = b.querySelector('.referenceDiv').getAttribute('data-' + sortBy);

if (sortBy === 'year') {
return parseInt(aValue) - parseInt(bValue);
} else {
return aValue.localeCompare(bValue);
}
});

refList.innerHTML = '';
items.forEach(item => refList.appendChild(item));
});
});
</script>
</head>
<body>
Expand Down