Skip to content

Conversation

Girik1105
Copy link

@Girik1105 Girik1105 commented Sep 26, 2025

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

(you can copy the ticket if it hasn't changed)

VSPC-215
User should be able to specify space title and description in multiple languages

Description
If there are multiple languages specified for an exhibition, the user should be able to enter text for a slide in each language.

VSPC-214
Users should be able to provide Slide texts in multiple languages

Description
If there are multiple languages defined for an exhibition, staff users should be able to specify space title and description for each language.

VSPC-232
it should be possible to specify about text in multiple languages

Description
According to the languages specified for a virtual space.

Anything else the reviewer needs to know?

... describe here ...

Prachi Kharge and others added 30 commits September 21, 2022 15:57
pooja-thalur and others added 28 commits August 15, 2024 16:27
# Conflicts:
#	vspace/src/main/java/edu/asu/diging/vspace/core/factory/ISpaceFactory.java
#	vspace/src/test/java/edu/asu/diging/vspace/config/ExhibitionLanguageConfigTest.java
# Conflicts:
#	vspace/src/main/java/edu/asu/diging/vspace/core/services/ISpaceManager.java
#	vspace/src/main/java/edu/asu/diging/vspace/core/services/impl/SpaceManager.java
# Conflicts:
#	vspace/src/main/java/edu/asu/diging/vspace/core/model/impl/Exhibition.java
#	vspace/src/main/java/edu/asu/diging/vspace/core/model/impl/ExhibitionLanguage.java
#	vspace/src/main/java/edu/asu/diging/vspace/core/services/IExhibitionManager.java
#	vspace/src/main/java/edu/asu/diging/vspace/core/services/impl/ExhibitionManager.java
#	vspace/src/main/java/edu/asu/diging/vspace/web/staff/ExhibitionConfigurationController.java
#	vspace/src/test/java/edu/asu/diging/vspace/core/services/impl/ExhibitionManagerTest.java
…uage title and description - still needs fix
@diging-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@diging-jenkins
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants