story/VSPC-216 #367
Open
story/VSPC-216 #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rating slideform, exhibitionaboutPageForm methods into their own factories.
…that are not default.
…on for non-default languages.
…dundacy of methods.
# Conflicts: # vspace/src/main/java/edu/asu/diging/vspace/core/services/impl/ExhibitionManager.java # vspace/src/main/java/edu/asu/diging/vspace/web/staff/AddSpaceController.java
…SPC-216 # Conflicts: # vspace/src/main/java/edu/asu/diging/vspace/core/services/ISlideManager.java # vspace/src/main/java/edu/asu/diging/vspace/core/services/impl/SlideManager.java
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
If there are multiple languages defined, users of the public exhibition should be able to switch between them
Description
there needs to be a menu item to switch languages. Depending on the selected language, text content is shown in that language. By default the default language should be shown. If something doesn’t have text provided in the selected language (e.g. French is selected but there is no title and description for a space in French), then the default language should be shown.
Anything else the reviewer needs to know?
... describe here ...