Skip to content

Conversation

Girik1105
Copy link
Contributor

@Girik1105 Girik1105 commented Mar 12, 2025

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

Write tests for Vogon

VOGRE-61

Are there any other pull requests that this one depends on?

Anything else the reviewer needs to know?

... describe here ...

@diging-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@jdamerow
Copy link
Member

jdamerow commented Apr 7, 2025

The tests fail because the actions can only run Python 3.9 but not all dependencies work with Python 3.9 (e.g. anyjson, which apparently is abandoned. There is a PR to upgrade to 3.13, maybe here, let's go with 3.9 and then go from there to 3.13 in the other ticket.

@jdamerow jdamerow closed this Apr 7, 2025
@Girik1105 Girik1105 reopened this May 16, 2025
@jdamerow
Copy link
Member

I think the workflow file needs to be updated to run with the correct python version.

@jdamerow jdamerow closed this May 19, 2025
@Girik1105 Girik1105 reopened this May 23, 2025
@jdamerow
Copy link
Member

jdamerow commented Jun 3, 2025

Tests are failing.

@jdamerow jdamerow closed this Jun 3, 2025
@Girik1105 Girik1105 reopened this Jun 5, 2025
@jdamerow
Copy link
Member

jdamerow commented Jun 6, 2025

Tests are failing.

@jdamerow jdamerow closed this Jun 6, 2025
@Girik1105 Girik1105 reopened this Jun 6, 2025
@Girik1105 Girik1105 closed this Jun 6, 2025
@Girik1105 Girik1105 reopened this Jun 6, 2025
@Girik1105
Copy link
Contributor Author

Tests are failing.

All tests work now! There was an issue in the django.yml configuration and the POSTGRES configuration in settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants