Skip to content

Conversation

Girik1105
Copy link
Contributor

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

When searching for concepts during annotating, VIAF needs to be searched as well.

Description
Besides Conceptpower, VIAF should also be searched. The search results should show exact matches first from Conceptpower and then from VIAF, and then other results (first conceptpower then VIAF).

VOGRE-43

Are there any other pull requests that this one depends on?

#76
#59

Anything else the reviewer needs to know?

Girik1105 and others added 30 commits August 9, 2024 17:59
…ory text import for importing and repository text for details
@diging-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@Girik1105 Girik1105 changed the title Story/vogre 43 story/VOGRE-43 May 30, 2025
Base automatically changed from story/VOGRE-7-V2 to develop June 6, 2025 16:17
@jdamerow
Copy link
Member

jdamerow commented Jun 6, 2025

Resolve conflicts please

@jdamerow jdamerow closed this Jun 6, 2025
@Girik1105 Girik1105 reopened this Jun 6, 2025
@Girik1105 Girik1105 closed this Jun 6, 2025
@Girik1105 Girik1105 reopened this Jun 6, 2025
@Girik1105 Girik1105 marked this pull request as ready for review June 6, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants