Skip to content

Conversation

rajvi-patel-22
Copy link
Member

@rajvi-patel-22 rajvi-patel-22 commented Jun 3, 2025

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

File doesn't show up after upload

Description
Not sure if it’s a caching issue or an issue with two files, but for: Citesphere

In Vogon, I only see the “Files are still being processed in Giles. Please check back later.” message, although one file is done processing. That should show up for annotation.

Are there any other pull requests that this one depends on?

Anything else the reviewer needs to know?

... describe here ...

@diging-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review June 3, 2025 23:03
@rajvi-patel-22 rajvi-patel-22 requested a review from jdamerow June 3, 2025 23:04
@jdamerow
Copy link
Member

jdamerow commented Jun 6, 2025

Make it so, Jenkins.

1 similar comment
@jdamerow
Copy link
Member

jdamerow commented Jun 6, 2025

Make it so, Jenkins.

@jdamerow
Copy link
Member

jdamerow commented Jun 6, 2025

It should show the files that are done being processed. There is one file that's done, the other one is not. I need to be able to annotate the file that is done.

@jdamerow jdamerow closed this Jun 6, 2025
@rajvi-patel-22 rajvi-patel-22 changed the base branch from develop to story/VOGRE-73 June 13, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants