Conversation
techncl
reviewed
Jan 12, 2026
Contributor
techncl
left a comment
techncl
left a comment
There was a problem hiding this comment.
Looks good! Just some minor comments.
| Assert.assertFalse(validatorRequest.validatorRequest().skipFileChecks()); | ||
| Assert.assertEquals(4096, validatorRequest.validatorRequest().maxCharsPerCellLimit()); | ||
| CsvValidatorJavaBridge.ValidationResult validationResult = (CsvValidatorJavaBridge.ValidationResult) result; | ||
| Assert.assertEquals("csvFile", validationResult.validatorRequest().csvFile()); |
Contributor
There was a problem hiding this comment.
Just curious, do we need to do validationResult.validatorRequest() each time? Couldn't we save it to a variable? same question for each test
Contributor
Author
There was a problem hiding this comment.
We could. I just renamed the 'Result' variable which was called 'Request' earlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java API had a
Resultinterface which needs to return errors from the corresponding implementation classes instead of an emptyArrayListdefined in the interface.Requestinterface as it is not needed (all setups happen through the builder pattern)Request