Skip to content

Enable verification of VCBs. #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 10, 2025
Merged

Enable verification of VCBs. #93

merged 9 commits into from
Apr 10, 2025

Conversation

dlongley
Copy link
Member

@dlongley dlongley commented Apr 8, 2025

No description provided.

@dlongley dlongley requested review from msporny and tminard April 8, 2025 01:00
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 84.30657% with 43 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (a41797a) to head (a013b7f).

Files with missing lines Patch % Lines
lib/vcb.js 83.72% 28 Missing ⚠️
lib/envelopes.js 73.21% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   79.94%   80.45%   +0.50%     
==========================================
  Files          12       13       +1     
  Lines        1905     2123     +218     
==========================================
+ Hits         1523     1708     +185     
- Misses        382      415      +33     
Files with missing lines Coverage Δ
lib/config.js 100.00% <100.00%> (ø)
lib/di.js 100.00% <100.00%> (ø)
lib/documentLoader.js 86.62% <100.00%> (ø)
lib/index.js 100.00% <100.00%> (ø)
lib/suites.js 98.73% <100.00%> (+0.08%) ⬆️
lib/verify.js 99.07% <100.00%> (+0.04%) ⬆️
lib/envelopes.js 78.57% <73.21%> (+4.06%) ⬆️
lib/vcb.js 83.72% <83.72%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41797a...a013b7f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dlongley dlongley merged commit d9d05e1 into main Apr 10, 2025
4 checks passed
@dlongley dlongley deleted the vcb-envelopes branch April 10, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants