Be more strict and prevent incomplete patterns

[amitaibu]

fixes #1681

[amitaibu]

I didn't get any error when running devenv up locally—it's as if it doesn't have any effect. Let's see if GH actions will get an error.

[amitaibu]

@mpscholten Errors on GH actions don't seem to be related.

I believe it's coming from master, but I don't understand why it sometimes works on master and sometimes doesn't.

[mpscholten]

For it to work inside the app itself we need to add it to https://github.com/digitallyinduced/ihp/blob/master/ihp-ide/lib/IHP/applicationGhciConfig aswell 👍

[mpscholten]

I tried to reproduce the tests error but it works locally when checking out this branch. So let's ignore that for now

[georgefst]

Personally, I'm of the view that -Werror should only be enabled on CI or similar, and gets in the way during development. I like to be able to test incomplete code, and often go in the opposite direction, enabling -fdefer-typed-holes and even -fdefer-type-errors.

Point is, some users would complain about this becoming the default, especially if it's hard to turn off. Perhaps the focus should instead be on making it easy to configure. It's not currently clear how to enable GHC options in IHP at all (see also #1455 (comment)).

[mpscholten]

@georgefst agree 👍