Add _type to all Telegram API objects in ndjson #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianroberts
force-pushed
the
telegram-type-in-list
branch
from
1acae30
to
0314897
Compare
|
Rebased on latest master |
Previously SearchTelegram.serialize_obj would only add the "_type" tag to the JSON object representing a TLObject if that object was an immediate child property of another TLObject - other cases would not add the _type, in particular - where a TLObject has a property whose value is a *list* of other TLObjects, the members of the list would not have a _type in the JSON - this is most noticeable for things like Message.entities, Page.blocks, etc. - the initial object passed in to serialize_obj did not have a _type added
- 'if type(value).__module__[0:8] == "telethon"' is subsumed by 'if type(value) not in scalars and value is not None' - 'if type(value) is dict' is unreachable since dict is not in scalars, so the loop will already have continue-d at the previous condition
ianroberts
force-pushed
the
telegram-type-in-list
branch
from
0314897
to
dc6822d
Compare
|
Thanks! |
ianroberts
added a commit
to GateNLP/4cat
that referenced
this pull request
Aug 22, 2023
Includes USFD-submitted pull requests digitalmethodsinitiative#368 and digitalmethodsinitiative#371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367
Currently when serializing Telegram TL schema objects to ndjson the
_typetag (giving the type of the relevant API object) is only included in some places and is omitted in others, most notably when serializing a list of objects rather than a single one. This PR updatesSearchTelegram.serialize_objto include the_typetag in all cases, by adding it immediately before returning rather than making it a special case added only to certain child properties.