Telegram: Restore the user_id property when resolving users #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianroberts
force-pushed
the
telegram-keep-resolved-user-id
branch
from
0fa57f5
to
5d7d639
Compare
|
Rebased on latest master |
|
Hi @ianroberts , thanks for this and apologies for the delay. If you could sync your branch with the master branch once more I will merge this. |
When resolving a PeerUser to a full_user, resolve_groups will now re-insert the original user_id property in the generated dictionary (so the ID is always accessible at the same JSON path whether or not we chose to resolve references). This mirrors the existing behaviour for resolving channels.
ianroberts
force-pushed
the
telegram-keep-resolved-user-id
branch
from
5d7d639
to
5060b96
Compare
|
Done, thanks. |
ianroberts
added a commit
to GateNLP/4cat
that referenced
this pull request
Aug 22, 2023
Includes USFD-submitted pull requests digitalmethodsinitiative#368 and digitalmethodsinitiative#371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchTelegram.resolve_groupstakes the minimal ID information inPeerUserandPeerChannelobjects within a Telegram message and expands them to their full user/channel objects respectively. In the case of channels the method re-inserts the originalchannel_idproperty into the JSON, which is useful as it means that code that processes the output JSON but only cares about the channel ID can work unchanged whether it is given resolved or unresolved JSON as input.However this is not currently done for users, so downstream code needs to be aware of this and pull the ID from either
user_idorfull_user.idas appropriate.This PR extends the channel behaviour to users, re-inserting the original
user_idproperty in its original place.