refactor download_videos to use proxies#551
Merged
Conversation
Member
Author
|
tested w/ proxies. tested ytdlp backup. all seems good. |
Member
Author
|
https://github.com/mahirox36/AsyncYT needs python 3.12. leaving it for the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested this successfully without proxies. Which is nice (both direct downloads and
yt_dlpwork well). It attempts to download as many direct video links first then if max has not been reached will tryyt_dlp. This is mainly due toyt_dlpnot supporting async (though we do pass the proxies).yt_dlpandffmpegto work asynchronously