-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop into master #408
base: master
Are you sure you want to change the base?
Commits on Oct 1, 2018
-
First fortifications against phrases ¨longer than 60 characters in a …
…new bin, both at the web UI and further down the stack.
Configuration menu - View commit details
-
Copy full SHA for 841b5fe - Browse repository at this point
Copy the full SHA 841b5feView commit details
Commits on Oct 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d3ae0fb - Browse repository at this point
Copy the full SHA d3ae0fbView commit details -
Added a small test suite, which now also relies on the create_new_bin…
… to throw an exception in addition to an error message for humans. This is a risky move up the stack I might think, if it is not caught under normal operations.
Configuration menu - View commit details
-
Copy full SHA for 540d385 - Browse repository at this point
Copy the full SHA 540d385View commit details -
Added a small test suite, which now also relies on the create_new_bin…
… to throw an exception in addition to an error message for humans. This is a risky move up the stack I might think, if it is not caught under normal operations.
Configuration menu - View commit details
-
Copy full SHA for 35a8b0b - Browse repository at this point
Copy the full SHA 35a8b0bView commit details -
Merge branch 'phrases_must_not_exceed_60chrs_each' of https://github.…
…com/xmacex/dmi-tcat into phrases_must_not_exceed_60chrs_each
Configuration menu - View commit details
-
Copy full SHA for f5fb3d7 - Browse repository at this point
Copy the full SHA f5fb3d7View commit details -
Fixed a minor typo of a test data set name. I'll be honest, this is a…
… procrastination commit under cognitive stress of getting all the tests in place. Please bear with me.
Configuration menu - View commit details
-
Copy full SHA for 25e4baa - Browse repository at this point
Copy the full SHA 25e4baaView commit details -
Added checks against long query phrases to the query modification fun…
…ctionality in modify_bin() too. On the UI side the same validateQuery() is used as when making a new bin, so I that should be fine.
Configuration menu - View commit details
-
Copy full SHA for e11cafe - Browse repository at this point
Copy the full SHA e11cafeView commit details
Commits on Nov 10, 2018
-
Documentation update for the capture form to inform the user of the 6…
…0chrs limit on phrases.
Configuration menu - View commit details
-
Copy full SHA for 27aa81f - Browse repository at this point
Copy the full SHA 27aa81fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b02847 - Browse repository at this point
Copy the full SHA 0b02847View commit details
Commits on Nov 13, 2018
-
A number of renames. This is basically me procrastinating before gett…
…ing on a more substantial task of adding tests in TDD style. Feedback provided by PHP Code Sniffer with default settings.
Configuration menu - View commit details
-
Copy full SHA for 026ea8a - Browse repository at this point
Copy the full SHA 026ea8aView commit details -
Nope, stick to the file names of the codebase when naming tests. This…
… is not an OOP project.
Configuration menu - View commit details
-
Copy full SHA for 4f987a2 - Browse repository at this point
Copy the full SHA 4f987a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a01571 - Browse repository at this point
Copy the full SHA 9a01571View commit details -
Added the scenario where a list of keywords is at surface level too l…
…ong because there is too much whitespace in the middle of it.
Configuration menu - View commit details
-
Copy full SHA for 14e332b - Browse repository at this point
Copy the full SHA 14e332bView commit details -
Ok validate_capture_phrases() should now catch phrases which are over…
… 60 characters long, even some weird ones.
Configuration menu - View commit details
-
Copy full SHA for df582ee - Browse repository at this point
Copy the full SHA df582eeView commit details -
Dropped the test suite of this branch of changes. I'll keep using the…
…m locally though, but not committing.
Configuration menu - View commit details
-
Copy full SHA for 2ccf102 - Browse repository at this point
Copy the full SHA 2ccf102View commit details -
Whoops I had misunderstood what search.php takes as input; it take th…
…e format familiar from the Twitter UI with disjunctions marked by ' OR ' instead of the comma ',' as the query bin manager thing on TCAT. Updated tests pass (hmm how can I have a test suite that I can commit to, but that does not get pushed to the repo? Maybe a separate project outside of the dmi-tcat top directory or something. Anyway...).
Configuration menu - View commit details
-
Copy full SHA for dbcba7f - Browse repository at this point
Copy the full SHA dbcba7fView commit details
Commits on Jan 3, 2019
-
Attempt to make bin removal and info lookup more robust.
Sometimes deleting large query bins can fail or timeout, removing the tweet tables but not the entry from the bins table. This results in the app crashing when accessing the capture page. This change attempts to prevent this by a) putting deletion operations in a single transaction and b) catching errors when retrieving bin info. The latter change is required because MySQL does not do schema changes such as table deletion in transactions so the problem with incomplete bin removal can still occur.
Configuration menu - View commit details
-
Copy full SHA for 4d76576 - Browse repository at this point
Copy the full SHA 4d76576View commit details
Commits on Feb 23, 2020
-
Merge branch 'master' into phrases_must_not_exceed_60chrs_each
niczem authoredFeb 23, 2020 Configuration menu - View commit details
-
Copy full SHA for f3859dc - Browse repository at this point
Copy the full SHA f3859dcView commit details
Commits on Mar 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0ba9a0e - Browse repository at this point
Copy the full SHA 0ba9a0eView commit details
Commits on Jun 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7f515ce - Browse repository at this point
Copy the full SHA 7f515ceView commit details
Commits on Jun 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 36ea4c8 - Browse repository at this point
Copy the full SHA 36ea4c8View commit details
Commits on Jul 8, 2020
-
Merge pull request #343 from mikesname/query_lookup_errors into develop
Attempt to make bin removal and info lookup more robust.
niczem authoredJul 8, 2020 Configuration menu - View commit details
-
Copy full SHA for 0319896 - Browse repository at this point
Copy the full SHA 0319896View commit details -
Merge pull request #402 from tmantynen/master
Consider all DB-collations beginning w/ 'utf8mb4' to be utf8mb4 collations
niczem authoredJul 8, 2020 Configuration menu - View commit details
-
Copy full SHA for 484a16a - Browse repository at this point
Copy the full SHA 484a16aView commit details -
Merge pull request #389 from eeftychiou/searchfix
Removed recursive call to search
niczem authoredJul 8, 2020 Configuration menu - View commit details
-
Copy full SHA for 0d4d4e8 - Browse repository at this point
Copy the full SHA 0d4d4e8View commit details -
Merge pull request #335 from xmacex/phrases_must_not_exceed_60chrs_each
Phrases must not exceed 60chrs each
niczem authoredJul 8, 2020 Configuration menu - View commit details
-
Copy full SHA for 41204fd - Browse repository at this point
Copy the full SHA 41204fdView commit details