Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into master #408

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Merge develop into master #408

wants to merge 25 commits into from

Commits on Oct 1, 2018

  1. First fortifications against phrases ¨longer than 60 characters in a …

    …new bin, both at the web UI and further down the stack.
    xmacex committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    841b5fe View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. Configuration menu
    Copy the full SHA
    d3ae0fb View commit details
    Browse the repository at this point in the history
  2. Added a small test suite, which now also relies on the create_new_bin…

    … to throw an exception in addition to an error message for humans. This is a risky move up the stack I might think, if it is not caught under normal operations.
    xmacex committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    540d385 View commit details
    Browse the repository at this point in the history
  3. Added a small test suite, which now also relies on the create_new_bin…

    … to throw an exception in addition to an error message for humans. This is a risky move up the stack I might think, if it is not caught under normal operations.
    xmacex committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    35a8b0b View commit details
    Browse the repository at this point in the history
  4. Merge branch 'phrases_must_not_exceed_60chrs_each' of https://github.…

    …com/xmacex/dmi-tcat into phrases_must_not_exceed_60chrs_each
    xmacex committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    f5fb3d7 View commit details
    Browse the repository at this point in the history
  5. Fixed a minor typo of a test data set name. I'll be honest, this is a…

    … procrastination commit under cognitive stress of getting all the tests in place. Please bear with me.
    xmacex committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    25e4baa View commit details
    Browse the repository at this point in the history
  6. Added checks against long query phrases to the query modification fun…

    …ctionality in modify_bin() too. On the UI side the same validateQuery() is used as when making a new bin, so I that should be fine.
    xmacex committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    e11cafe View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2018

  1. Documentation update for the capture form to inform the user of the 6…

    …0chrs limit on phrases.
    xmacex committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    27aa81f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b02847 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. A number of renames. This is basically me procrastinating before gett…

    …ing on a more substantial task of adding tests in TDD style. Feedback provided by PHP Code Sniffer with default settings.
    xmacex committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    026ea8a View commit details
    Browse the repository at this point in the history
  2. Nope, stick to the file names of the codebase when naming tests. This…

    … is not an OOP project.
    xmacex committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    4f987a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9a01571 View commit details
    Browse the repository at this point in the history
  4. Added the scenario where a list of keywords is at surface level too l…

    …ong because there is too much whitespace in the middle of it.
    xmacex committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    14e332b View commit details
    Browse the repository at this point in the history
  5. Ok validate_capture_phrases() should now catch phrases which are over…

    … 60 characters long, even some weird ones.
    xmacex committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    df582ee View commit details
    Browse the repository at this point in the history
  6. Dropped the test suite of this branch of changes. I'll keep using the…

    …m locally though, but not committing.
    xmacex committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    2ccf102 View commit details
    Browse the repository at this point in the history
  7. Whoops I had misunderstood what search.php takes as input; it take th…

    …e format familiar from the Twitter UI with disjunctions marked by ' OR ' instead of the comma ',' as the query bin manager thing on TCAT. Updated tests pass (hmm how can I have a test suite that I can commit to, but that does not get pushed to the repo? Maybe a separate project outside of the dmi-tcat top directory or something. Anyway...).
    xmacex committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    dbcba7f View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Attempt to make bin removal and info lookup more robust.

    Sometimes deleting large query bins can fail or timeout, removing
    the tweet tables but not the entry from the bins table. This
    results in the app crashing when accessing the capture page.
    
    This change attempts to prevent this by a) putting deletion
    operations in a single transaction and b) catching errors when
    retrieving bin info. The latter change is required because MySQL
    does not do schema changes such as table deletion in transactions
    so the problem with incomplete bin removal can still occur.
    mikesname committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    4d76576 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2020

  1. Configuration menu
    Copy the full SHA
    f3859dc View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Configuration menu
    Copy the full SHA
    0ba9a0e View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Configuration menu
    Copy the full SHA
    7f515ce View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Configuration menu
    Copy the full SHA
    36ea4c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Merge pull request #343 from mikesname/query_lookup_errors into develop

    Attempt to make bin removal and info lookup more robust.
    niczem authored Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0319896 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #402 from tmantynen/master

    Consider all DB-collations beginning w/ 'utf8mb4' to be utf8mb4 collations
    niczem authored Jul 8, 2020
    Configuration menu
    Copy the full SHA
    484a16a View commit details
    Browse the repository at this point in the history
  3. Merge pull request #389 from eeftychiou/searchfix

    Removed recursive call to search
    niczem authored Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0d4d4e8 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #335 from xmacex/phrases_must_not_exceed_60chrs_each

    Phrases must not exceed 60chrs each
    niczem authored Jul 8, 2020
    Configuration menu
    Copy the full SHA
    41204fd View commit details
    Browse the repository at this point in the history