Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add LUKS encryption #337

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

edeckers
Copy link

@edeckers edeckers commented Aug 11, 2020

This PR will add support for LUKS encryption, as mentioned in #311. Code is mostly taken from cloudscale-ch/csi-cloudscale.

@edeckers edeckers marked this pull request as draft September 23, 2020 10:54
@edeckers edeckers force-pushed the elydeckers/feature/add-luks-support branch from 2946736 to 6d32375 Compare September 24, 2020 11:37
@edeckers edeckers force-pushed the elydeckers/feature/add-luks-support branch from 6d32375 to bc2364c Compare January 18, 2021 08:43
@edeckers edeckers force-pushed the elydeckers/feature/add-luks-support branch from bc2364c to 6bad871 Compare February 20, 2021 15:47
@edeckers edeckers force-pushed the elydeckers/feature/add-luks-support branch 2 times, most recently from f9ac8d5 to 34242f8 Compare March 18, 2022 19:22
@edeckers edeckers force-pushed the elydeckers/feature/add-luks-support branch from 34242f8 to 795fd5c Compare March 18, 2022 19:24
@lukasskopos
Copy link

Any progress here?

@edeckers
Copy link
Author

edeckers commented Nov 22, 2022

Hi @lukasskopos , thank you for your message :)

Every once in a while I update this branch for myself, so I can use it on my own instance. But since this works good enough for me and I don't have much time to spare these days, I'm not planning on doing any extra development on it.

I don't recall running into any major issues with this code, so I think the main todos are:

  1. Adding some useful tests
  2. Check whether or not merging this code is in violation of the cloudscale-ch/csi-cloudscale license, where I took most of the code from, as mentioned in the first message of this thread.

@davidhalter
Copy link

Check whether or not merging this code is in violation of the cloudscale-ch/csi-cloudscale license

It's not in violation of our license. Feel free to steal it :)

@edeckers
Copy link
Author

Check whether or not merging this code is in violation of the cloudscale-ch/csi-cloudscale license

It's not in violation of our license. Feel free to steal it :)

Wow, that was quick 😅 , thank you!

@paravibe paravibe mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants