Add optional flags for DOKS control plane firewall feature#1540
Merged
danaelhe merged 7 commits intodigitalocean:mainfrom Jun 20, 2024
Merged
Add optional flags for DOKS control plane firewall feature#1540danaelhe merged 7 commits intodigitalocean:mainfrom
danaelhe merged 7 commits intodigitalocean:mainfrom
Conversation
…' into olove/add-control-plane-firewall
llDrLove
force-pushed
the
olove/add-control-plane-firewall
branch
4 times, most recently
from
48a3391 to
c316163
Compare
llDrLove
force-pushed
the
olove/add-control-plane-firewall
branch
from
c316163 to
0c61f59
Compare
Contributor
Author
|
Hi @bbassingthwaite , I needed to adjust some of the LB tests when introducing the godo bump to |
|
LGTM thanks for fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional flags for the control plane firewall feature.
This is still a per/user feature and can't be used by every DOKS users.
Also, I needed to update to godo 0.117.0 which has the new request parameters.