Skip to content

updated code to support array of stacks for nested exceptions #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated code to support array of stacks for nested exceptions #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/analyticsProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ export enum Impact
LOW = "Low",
}

export interface IErrorFlowStack{
exceptionType: string;
frames: IErrorFlowFrame[];
}

export interface IErrorFlowFrame{
moduleName: string;
functionName: string;
Expand All @@ -24,7 +29,7 @@ export interface IErrorFlowResponse
stackTrace: string;
exceptionMessage: string;
exceptionType: string;
frames: IErrorFlowFrame[];
frameStacks: IErrorFlowStack[];
}

export interface IErrorFlowSummary
Expand Down
6 changes: 5 additions & 1 deletion src/views/errorFlowStackView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,13 @@ class ErrorFlowDetailsViewProvider implements vscode.WebviewViewProvider, vscode

private getHtml(errorFlow: IErrorFlowResponse | undefined, originCodeObjectId: string | undefined) : string
{
const framesHtml = errorFlow?.frames.reverse()

const framesHtml = errorFlow?.frameStacks.flatMap(f=> f.frames).reverse()
.map(f => this.getFrameItemHtml(f, originCodeObjectId!))
.join('') ?? '';
// const framesHtml = errorFlow?.frameStacks[0].frames.reverse()
// .map(f => this.getFrameItemHtml(f, originCodeObjectId!))
// .join('') ?? '';
const checked = Settings.hideFramesOutsideWorkspace ? "checked" : "";

return /*html*/ `
Expand Down