Skip to content

Log duplicate method infos #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Log duplicate method infos #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions src/views/codeAnalytics/insightsViewTab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { HtmlHelper, ICodeAnalyticsViewTab } from "./common";
import { Logger } from "../../services/logger";
import { IInsightListViewItemsCreator } from "./InsightListView/IInsightListViewItemsCreator";
import { ListViewRender } from "../ListView/ListViewRender";
import { DocumentInfoProvider } from "../../services/documentInfoProvider";
import { DocumentInfoProvider, MethodInfo } from "../../services/documentInfoProvider";
import { ICodeObjectScopeGroupCreator } from "./CodeObjectGroups/ICodeObjectScopeGroupCreator";
import { CodeObjectGroupDiscovery } from "./CodeObjectGroups/CodeObjectGroupDiscovery";
import { EmptyGroupItemTemplate } from "../ListView/EmptyGroupItemTemplate";
Expand Down Expand Up @@ -82,7 +82,25 @@ export class InsightsViewTab implements ICodeAnalyticsViewTab
return;
}

const methodInfo = docInfo.methods.single(x => x.id == codeObject.id);
let methodInfo: MethodInfo;
const methodInfos = docInfo.methods.filter(x => x.id === codeObject.id);
if(methodInfos.length === 0) {
throw new Error(`no method infos were found for code object id ${codeObject.id}`);
}
else {
methodInfo = methodInfos[0];

if(methodInfos.length > 1) {
const methodInfoData = methodInfos
.map((methodInfo: MethodInfo) =>
`\tname: ${methodInfo.name}, displayName: ${methodInfo.displayName}, documetUri: ${methodInfo.documentUri}, nameRange: ${methodInfo.nameRange?.start.line}:${methodInfo.nameRange?.start.character}-${methodInfo.nameRange?.end.line}:${methodInfo.nameRange?.end.character}, symbol: ${methodInfo.symbol.name}@${methodInfo.symbol.codeLocation}`
)
.join('\n');
Logger.warn(`refreshListViewRequested: found too many method infos with the same code object id: ${codeObject.id}\n${methodInfoData}`);
methodInfo = methodInfos[0];
}
}

const codeObjectsIds = methodInfo.getIds(true, true);

Logger.info('Insight codeobjectIds:\n'+codeObjectsIds.join('\n'));
Expand All @@ -92,7 +110,7 @@ export class InsightsViewTab implements ICodeAnalyticsViewTab
relevantInsight=[];
}

responseItems =relevantInsight;
responseItems =relevantInsight;

// responseItems = await this._analyticsProvider.getInsights(codeObjectsIds,true);
//temp ugly workaround
Expand All @@ -108,10 +126,7 @@ export class InsightsViewTab implements ICodeAnalyticsViewTab
for (const duplicate of duplicates){
duplicateSpansItems.push(new DuplicateSpanInsight(duplicate, this._viewUris));
responseItems=responseItems.filter(x=>x.codeObjectId!=duplicate.id);


}


usageResults = docInfo.usageData.getForCodeObjectIds(codeObjectsIds);
if (!this._workspaceState.environment &&
Expand Down