Draft
Conversation
zandre-eng
previously approved these changes
Jul 11, 2024
Collaborator
zandre-eng
left a comment
zandre-eng
left a comment
There was a problem hiding this comment.
Good to test the compileSdk version once merged. I believe we did have some issues in the past where the Tech5 libraries weren't happy when we fiddled with the version.
Contributor
Author
That's great to know, thanks! |
avazirna
approved these changes
Jul 11, 2024
Contributor
avazirna
left a comment
avazirna
left a comment
There was a problem hiding this comment.
The only note is to make sure this gets tested on at least 2 devices from different brands. We have in the past faced issues with the app completely crashing in same devices models, which only got resolved after combining different versions of the libraries from sample apps they shared with us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will get these tested once merged.