[B5] Split domain app #35349
Open
[B5] Split domain app #35349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rates.html, splitting templates"
…ect_privacy.html, splitting templates"
…lling_info.html, splitting templates"
….html, splitting templates"
…very_measures_history.html, splitting templates"
…ndar_fixture.html, splitting templates"
…_alert.html, splitting templates"
…_basic.html, splitting templates"
…alculations.html, splitting templates"
…bscription_renewal.html, splitting templates"
…management.html, splitting templates"
…eases_by_app_profile.html, splitting templates"
…in_invite.html, splitting templates"
…track_settings.html, splitting templates"
…ayment_modal.html, splitting templates"
…ling_contact_info.html, splitting templates"
…ds.html, splitting templates"
…sfer_domain_pending.html, splitting templates"
…al_sms_rates.html, splitting templates"
…icense_explanations.html, splitting templates"
…_search.html, splitting templates"
…tion_in_progress.html, splitting templates"
…ransfer_domain.html, splitting templates"
…an.html, splitting templates"
…age_content.html, splitting templates"
…s_and_privileges.html, splitting templates"
…nt_privilege_notification.html, splitting templates"
…sfer_domain.html, splitting templates"
…omain.html, splitting templates"
orangejenny
requested review from
esoergel,
biyeun and
nospame
as code owners
…d/password_reset_confirm.html, splitting templates"
…d/two_factor/core/login_form.html, splitting templates"
…d/two_factor/profile/disable.html, splitting templates"
…d/two_factor/_wizard_actions.html, splitting templates"
…d/two_factor/core/backup_tokens.html, splitting templates"
…d/password_reset_form.html, splitting templates"
…d/partials/password_reset_form_only.html, splitting templates"
…d/two_factor/core/setup_complete.html, splitting templates"
…d/two_factor/core/otp_required.html, splitting templates"
…d/two_factor/core/login.html, splitting templates"
…d/two_factor/core/setup.html, splitting templates"
…d/partials/login_full.html, splitting templates"
…d/two_factor/profile/profile.html, splitting templates"
…d/login.html, splitting templates"
…d/two_factor/core/phone_register.html, splitting templates"
…d/two_factor/_wizard_forms.html, splitting templates"
|
Added some commits to split the login_and_password pages, which are in a non-standard directory structure. |
millerdev
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This splits the domain app into B3 and B5 versions. There are ~50 views in this app, so it'll be migrated in multiple PRs.
Almost all commits are automated.
Safety Assurance
Safety story
The B5 code doesn't go live at this point, the only risk is of a file reference not getting renamed properly.
This process has been run numerous times on various apps. But this is an unusually large app and has some non-standard directory structures in the login templates, a high-risk area.
Automated test coverage
The migration tool has test coverage. The domain views probably have some coverage in QA's selenium smoke tests.
QA Plan
Requesting QA smoke test the login workflows: https://dimagi.atlassian.net/browse/QA-7239
Rollback instructions
Labels & Review