Skip to content

Pipeline routing info #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Pipeline routing info #1470

wants to merge 6 commits into from

Conversation

stephherbers
Copy link
Contributor

@stephherbers stephherbers commented Apr 16, 2025

Description

resolves #1138

User Impact

User will be able to access the routing information of the pipeline

Demo

n/a

Docs and Changelog

definite yes to both

@stephherbers stephherbers requested a review from snopoke April 16, 2025 15:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 45.00000% with 22 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/pipelines/nodes/base.py 15.38% 22 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stephherbers stephherbers requested a review from SmittieC April 22, 2025 19:15
@stephherbers stephherbers marked this pull request as ready for review April 22, 2025 19:15
Copy link
Contributor

@snopoke snopoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to work when running the graph. I think we will need to refactor our conditional edges to rather use the command pattern. I'll take a look at this.

I also received this error when trying to use the functions in a Python node:

apps.pipelines.exceptions.PipelineNodeRunError: 'dict' object has no attribute 'get_all_routes'

This is because the state is actually just a dict and not an instance of PipelineState.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose routing info in pipeline state
3 participants