Skip to content

[DO NOT MERGE] Rename 'channels' app to 'ocs_channels' #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

snopoke
Copy link
Contributor

@snopoke snopoke commented May 16, 2025

Warning

Do not merge.
This will be merged during the maintenance window.

Description

This renames the 'channels' app in preparation from adding the Django channels app to avoid a name clash.

The approach I've gone with is to keep the DB schema untouched but to change the app label. This is possible by setting the db_table on the model Meta class.

This will require a maintenance window in order to update references to the app label in the database (migrations and content type). See #1602

@snopoke snopoke changed the title Rename 'channels' app to 'ocs_channels' [DO NOT MERGE] Rename 'channels' app to 'ocs_channels' May 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/experiments/views/experiment.py 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@SmittieC SmittieC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

snopoke added 2 commits May 30, 2025 16:41
# Conflicts:
#	apps/teams/backends.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants